Skip to content

Commit 1184d9f

Browse files
litian1992longlimsft
authored andcommitted
net/mlx5: Not returning mlx5_link_info table when speed is unknown
Because mlx5e_link_info and mlx5e_ext_link_info have holes e.g. Azure mlx5 reports PTYS 19. Do not return it unless speed is retrieved successfully. Fixes: 65a5d35 ("net/mlx5: Refactor link speed handling with mlx5_link_info struct") Suggested-by: Vitaly Kuznetsov <vkuznets@redhat.com> Signed-off-by: Li Tian <litian@redhat.com> Reviewed-by: Tariq Toukan <tariqt@nvidia.com> Link: https://patch.msgid.link/20250910003732.5973-1-litian@redhat.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent db5c9fe commit 1184d9f

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

  • drivers/net/ethernet/mellanox/mlx5/core

drivers/net/ethernet/mellanox/mlx5/core/port.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1170,7 +1170,11 @@ const struct mlx5_link_info *mlx5_port_ptys2info(struct mlx5_core_dev *mdev,
11701170
mlx5e_port_get_link_mode_info_arr(mdev, &table, &max_size,
11711171
force_legacy);
11721172
i = find_first_bit(&temp, max_size);
1173-
if (i < max_size)
1173+
1174+
/* mlx5e_link_info has holes. Check speed
1175+
* is not zero as indication of one.
1176+
*/
1177+
if (i < max_size && table[i].speed)
11741178
return &table[i];
11751179

11761180
return NULL;

0 commit comments

Comments
 (0)