Skip to content

feat: add X-Goog-Request-Reason header support#207

Merged
rhgoogle merged 6 commits into
mainfrom
feat/request-reason-header
Apr 29, 2026
Merged

feat: add X-Goog-Request-Reason header support#207
rhgoogle merged 6 commits into
mainfrom
feat/request-reason-header

Conversation

@rhgoogle

Copy link
Copy Markdown
Contributor

Internal branch for PR #205 to run CI with access to secrets.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for the requestReason property in BigQuery connections, enabling the X-Goog-Request-Reason header to be sent with HTTP requests. The changes include extracting the property in BQConnection, updating authorization methods in Oauth2Bigquery to propagate the reason and user agent, and modifying the HttpRequestTimeoutInitializer to set the headers. A new test case verifies the header's presence. Review feedback identifies a typo in a method name, suggests maintaining private visibility for the internal initializer class, recommends using a constant for the header name, and advises adding @Nullable annotations for clarity.

Comment thread src/main/java/net/starschema/clouddb/jdbc/Oauth2Bigquery.java Outdated
Comment thread src/main/java/net/starschema/clouddb/jdbc/Oauth2Bigquery.java Outdated
Comment thread src/main/java/net/starschema/clouddb/jdbc/Oauth2Bigquery.java Outdated
Comment thread src/main/java/net/starschema/clouddb/jdbc/Oauth2Bigquery.java Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

@siyumiG siyumiG left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solve gemini-code-assit comment?

@rhgoogle
rhgoogle merged commit 8bb7b9f into main Apr 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants