Fix stale syncResponse state in overloaded executeQuery#209
Open
siyumiG wants to merge 1 commit into
Open
Conversation
If a query takes longer than 5 seconds (the sync query timeout), the driver leaves the statement in a state indicating the query is not done (jobComplete = false) inside the syncResponseFromCurrentQuery reference. The standard executeQuery(String) method correctly cleans up this state in its finally block. However, the overloaded method executeQuery(String, boolean) used for unlimited billing queries omitted this cleanup. Consequently, when Looker later calls close() (which invokes cancel()), the driver incorrectly thinks the query is still running and attempts to cancel it. This cancel request fails with a 400 Bad Request (if the query already finished) or a 403 Forbidden (if using restricted OAuth scopes), causing query results to be overwritten by a fatal "Failed to kill query" exception. This change adds `this.syncResponseFromCurrentQuery.set(null);` to the finally block of the overloaded executeQuery(String, boolean) method, aligning it with the standard execution path and preventing erroneous cancellation attempts. Bug: b/522228414, b/523362913
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates BQStatement.java to reset syncResponseFromCurrentQuery to null in the finally block of executeQuery to ensure proper state cleanup. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
siyumiG
force-pushed
the
fix-b522228414-state-cleanup
branch
from
June 16, 2026 00:15
9fd8cd3 to
158e2ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a query takes longer than 5 seconds (the sync query timeout), the driver leaves the statement in a state indicating the query is not done (jobComplete = false) inside the syncResponseFromCurrentQuery reference.
The standard executeQuery(String) method correctly cleans up this state in its finally block. However, the overloaded method executeQuery(String, boolean) used for unlimited billing queries omitted this cleanup.
Consequently, when Looker later calls close() (which invokes cancel()), the driver incorrectly thinks the query is still running and attempts to cancel it. This cancel request fails with a 400 Bad Request (if the query already finished) or a 403 Forbidden (if using restricted OAuth scopes), causing query results to be overwritten by a fatal "Failed to kill query" exception.
This change adds
this.syncResponseFromCurrentQuery.set(null);to the finally block of the overloaded executeQuery(String, boolean) method, aligning it with the standard execution path and preventing erroneous cancellation attempts.Bug: b/522228414, b/523362913