Skip to content

Fix stale syncResponse state in overloaded executeQuery#209

Open
siyumiG wants to merge 1 commit into
looker-open-source:mainfrom
siyumiG:fix-b522228414-state-cleanup
Open

Fix stale syncResponse state in overloaded executeQuery#209
siyumiG wants to merge 1 commit into
looker-open-source:mainfrom
siyumiG:fix-b522228414-state-cleanup

Conversation

@siyumiG

@siyumiG siyumiG commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

If a query takes longer than 5 seconds (the sync query timeout), the driver leaves the statement in a state indicating the query is not done (jobComplete = false) inside the syncResponseFromCurrentQuery reference.

The standard executeQuery(String) method correctly cleans up this state in its finally block. However, the overloaded method executeQuery(String, boolean) used for unlimited billing queries omitted this cleanup.

Consequently, when Looker later calls close() (which invokes cancel()), the driver incorrectly thinks the query is still running and attempts to cancel it. This cancel request fails with a 400 Bad Request (if the query already finished) or a 403 Forbidden (if using restricted OAuth scopes), causing query results to be overwritten by a fatal "Failed to kill query" exception.

This change adds this.syncResponseFromCurrentQuery.set(null); to the finally block of the overloaded executeQuery(String, boolean) method, aligning it with the standard execution path and preventing erroneous cancellation attempts.

Bug: b/522228414, b/523362913

If a query takes longer than 5 seconds (the sync query timeout),
the driver leaves the statement in a state indicating the query
is not done (jobComplete = false) inside the syncResponseFromCurrentQuery
reference.

The standard executeQuery(String) method correctly cleans up this
state in its finally block. However, the overloaded method
executeQuery(String, boolean) used for unlimited billing queries
omitted this cleanup.

Consequently, when Looker later calls close() (which invokes cancel()),
the driver incorrectly thinks the query is still running and attempts
to cancel it. This cancel request fails with a 400 Bad Request
(if the query already finished) or a 403 Forbidden (if using restricted
OAuth scopes), causing query results to be overwritten by a fatal
"Failed to kill query" exception.

This change adds `this.syncResponseFromCurrentQuery.set(null);` to the
finally block of the overloaded executeQuery(String, boolean) method,
aligning it with the standard execution path and preventing erroneous
cancellation attempts.

Bug: b/522228414, b/523362913

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates BQStatement.java to reset syncResponseFromCurrentQuery to null in the finally block of executeQuery to ensure proper state cleanup. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@siyumiG
siyumiG force-pushed the fix-b522228414-state-cleanup branch from 9fd8cd3 to 158e2ce Compare June 16, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant