Merge window#221
Conversation
1. Adds types and listeners for cancellable merge edit. 2. Adds demo of how to render merge edit in a embedded host application. 3. Deprecates getLookerVersion and replaces with getLookerMajorVersion and getLookerMinorVersion 4. Deprecates LookerUrlParam and provides alternate LookerUrlArgs
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @bryans99, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the embed SDK by adding support for the dashboard:tile:merge event. This allows embedding applications to intercept the default behavior of editing merged queries from dashboard tiles and implement custom handling, such as opening the edit page in a new window. A new demo page is included to showcase embedding the merge query edit experience.
Highlights
- New Event Support: Added support for the
dashboard:tile:mergeevent in the embed SDK. This event is fired when a user attempts to edit a merged query from a dashboard tile. - Custom Merge Edit Handling: Introduced a canceller callback (
openMergeQuery) that intercepts thedashboard:tile:mergeevent. This callback prevents the default behavior (opening the edit page within the same iframe) and instead opens the merge query edit page in a new browser window. - New Demo Page: Added a new demo page (
demo/demo_merge_edit_frame.htmland.ts) specifically designed to demonstrate embedding the 'Edit Merge Query' page itself. - Main Demo Update: Updated the main single-frame demo page (
demo/demo_single_frame.ts) to utilize the newdashboard:tile:mergeevent handler, ensuring consistency in how merge query edits are handled across demo contexts. - Documentation: Added documentation for the new
DashboardTileMergeEventinterface and updated existing documentation files to reflect the new event and associated types.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces functionality for handling merge query edits in a separate window, including new demo files (demo_merge_edit_frame.html and demo_merge_edit_frame.ts) and event handling for dashboard:tile:merge. It also includes updates to documentation to reflect new event types and interfaces.
My review focuses on improving type safety in the new TypeScript code and correcting a conditional logic for version checking. These changes will enhance code robustness and maintainability.
Bumps [http-proxy-middleware](https://github.com/chimurai/http-proxy-middleware) from 2.0.7 to 2.0.9. - [Release notes](https://github.com/chimurai/http-proxy-middleware/releases) - [Changelog](https://github.com/chimurai/http-proxy-middleware/blob/v2.0.9/CHANGELOG.md) - [Commits](chimurai/http-proxy-middleware@v2.0.7...v2.0.9) --- updated-dependencies: - dependency-name: http-proxy-middleware dependency-version: 2.0.9 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
2 participants
No description provided.