Skip to content

Fix multiple iframes when using merge query flow#263

Merged
bryans99 merged 3 commits into
masterfrom
bnr/fix-merge
Jul 6, 2026
Merged

Fix multiple iframes when using merge query flow#263
bryans99 merged 3 commits into
masterfrom
bnr/fix-merge

Conversation

@bryans99

@bryans99 bryans99 commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@bryans99 bryans99 requested a review from a team as a code owner July 6, 2026 20:51

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates 'src/EmbedClientEx.ts' to copy the callback arrays within the 'handlers' object. The review feedback suggests replacing the 'for...in' loop with 'Object.keys()' to safely iterate over only the object's own properties and avoid potential issues with prototype chain inheritance.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/EmbedClientEx.ts Outdated
@bryans99 bryans99 merged commit a331a0b into master Jul 6, 2026
13 checks passed
@bryans99 bryans99 deleted the bnr/fix-merge branch July 6, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants