Skip to content

fix: fixed dashboard cat and dashboard import to handle merge results properly#295

Merged
drstrangelooker merged 2 commits into
mainfrom
fix-merge-query
Jun 25, 2026
Merged

fix: fixed dashboard cat and dashboard import to handle merge results properly#295
drstrangelooker merged 2 commits into
mainfrom
fix-merge-query

Conversation

@drstrangelooker

Copy link
Copy Markdown
Collaborator

fixes #294

@drstrangelooker drstrangelooker requested a review from a team as a code owner June 25, 2026 18:45

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the dashboard commands by adding support for fetching and recreating merge queries and their source queries during dashboard cat and import operations. It also improves error handling for dashboard search and creation conflicts. The review feedback highlights a potential issue where a failed source query recreation could lead to using an incorrect query ID, and recommends resetting package-level global variables (dashboardImportPlain and dashboardImportForce) in test defer blocks to prevent test pollution.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread internal/cmd/dashboard.go
Comment thread internal/cmd/cmd_test.go Outdated
Comment thread internal/cmd/cmd_test.go Outdated
Comment thread internal/cmd/cmd_test.go Outdated
@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

CI Tests

  4 files   24 suites   0s ⏱️
 93 tests  93 ✅ 0 💤 0 ❌
372 runs  372 ✅ 0 💤 0 ❌

Results for commit 104a441.

♻️ This comment has been updated with latest results.

@drstrangelooker drstrangelooker merged commit d840385 into main Jun 25, 2026
19 checks passed
@drstrangelooker drstrangelooker deleted the fix-merge-query branch June 25, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dashboard cat omits merge_result body (only merge_result_id preserved), breaking round-trip for merge-query dashboards

1 participant