Skip to content

feat: project commit and project push#303

Open
drstrangelooker wants to merge 1 commit into
mainfrom
project-commit
Open

feat: project commit and project push#303
drstrangelooker wants to merge 1 commit into
mainfrom
project-commit

Conversation

@drstrangelooker

Copy link
Copy Markdown
Collaborator

No description provided.

@drstrangelooker drstrangelooker requested a review from a team as a code owner July 15, 2026 20:03

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the project commit and project push-branch commands to the Looker CLI, along with their corresponding unit tests. The feedback focuses on improving Go idiomaticity and robustness: first, by replacing the unidiomatic pointer-to-slice (*[]string) with a standard slice in the request struct, and second, by retrieving flag values directly from cmd.Flags() instead of relying on global variables to avoid state persistence issues across executions.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread internal/cmd/project.go
Comment thread internal/cmd/project.go
@github-actions

Copy link
Copy Markdown
Contributor

CI Tests

  4 files   24 suites   0s ⏱️
100 tests 100 ✅ 0 💤 0 ❌
400 runs  400 ✅ 0 💤 0 ❌

Results for commit 48643e4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant