Skip to content

fix(packages/sdk): import interface as type#1701

Open
SymphonySimper wants to merge 1 commit into
looker-open-source:mainfrom
SymphonySimper:main
Open

fix(packages/sdk): import interface as type#1701
SymphonySimper wants to merge 1 commit into
looker-open-source:mainfrom
SymphonySimper:main

Conversation

@SymphonySimper
Copy link
Copy Markdown

Hello!

Importing an interface/type without import type causes build failures in vite 8. Only this specific import caused issue in my case. But there could be other imports as well.

Thanks!

@SymphonySimper SymphonySimper requested a review from a team as a code owner April 14, 2026 09:26
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the export of ILooker40SDK in packages/sdk/src/index.ts to use a type-only export. I have no feedback to provide as there are no review comments to evaluate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant