fix: validate submit run ids and publish release assets#5
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea62d0ae67
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "version": tag, | ||
| "tag_name": tag, | ||
| "release_sha": release_sha, | ||
| "built_at": datetime.now(timezone.utc).isoformat().replace("+00:00", "Z"), |
There was a problem hiding this comment.
Make manifest generation deterministic for retries
When the Release Assets job is re-run with replace_existing=false after publish-assets already uploaded manifest.json but a later step failed, this timestamp is regenerated even if the downloaded binary artifacts are identical. The checksum verification then sees the existing manifest.json as different and exits before the intended “skip identical assets” path, making a failed publish job unretryable without deleting/replacing assets.
Useful? React with 👍 / 👎.
0ff527a to
708edb2
Compare
708edb2 to
0c11649
Compare
Summary
Release Assetsworkflow for binary asset publishing and v0.3.0 backfill.release_created == true.release-as: 0.3.0bootstrap forcing.Release asset root cause
The v0.3.0 Release Please run built Linux and macOS workflow artifacts, but
publish-assetsfailed before upload. The failing step calledgh release view "$TAG_NAME"without checkout/repo context, and the log ended with:The v0.3.0 GitHub Release currently has no uploaded assets. Backfill remains manual after this PR is merged via
Actions -> Release Assets -> Run workflowwithtag_name=v0.3.0,ref=v0.3.0,replace_existing=false.Verification
python3 -m json.tool release-please-config.json.github/workflows/release-please.yml,.github/workflows/release-assets.yml,.github/workflows/semantic-pr-title.ymlgo test ./internal/localexec ./internal/service ./internal/app ./cmd/codencergo test ./...make verify-public-releasegit diff --checkgit diff --cached --checkactionlintwas not installed locally, so that optional check was skipped.