Fix error "No target was found for the target framework" in MAUI projects

Author: loop8ack

.config/dotnet-tools.json

@@ -270,3 +270,9 @@ dotnet_diagnostic.CA2016.severity = warning
 
 # IDE0047: Remove unnecessary parentheses
 dotnet_diagnostic.IDE0047.severity = none
+
+# IDE0028: Collection initialization can be simplified
+dotnet_diagnostic.IDE0028.severity = none
+
+# IDE0290: Use primary constructor
+dotnet_diagnostic.IDE0290.severity = none

.editorconfig

@@ -5,7 +5,7 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <Version>0.2.0</Version>
+    <Version>0.2.1</Version>
     <Authors>Loop8ack</Authors>
     <PackageReadmeFile>ReadMe.md</PackageReadmeFile>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>

src/NuGet.Metadata.props

@@ -43,8 +43,6 @@ public IReadOnlyCollection<IPackageData> Read()
             ? FromIntermediateOutput(ProjectDirectory, BaseIntermediateOutputPath)
             : new AssetsFilePath(AssetsFilePath.Value);
 
-        IEnumerable<KnownPackageId> knownPackageIds = ParseKnownPackageIds(KnownPackageIds.Value).ToArray();
-
         IPackageDataReader reader = new PackageDataReader(assetsFilePath, TargetFramework, RuntimeIdentifier)
         {
             KnownPackageIds = ParseKnownPackageIds(KnownPackageIds.Value).ToArray()

src/PackScan.Analyzer/Core/Services/PackageDataReaderService.cs

@@ -1,6 +1,6 @@
 {
   "profiles": {
-    "PackageTools.Analyzer.Test": {
+    "Debug: PackScan.Analyzer.Test": {
       "commandName": "DebugRoslynComponent",
       "targetProject": "..\\..\\test\\PackScan.Analyzer.Test\\PackScan.Analyzer.Test.csproj"
     }

src/PackScan.Analyzer/Properties/launchSettings.json

@@ -23,12 +23,12 @@ public sealed class PackageDataReader : IPackageDataReader
     public AssetsFilePath AssetsFilePath { get; }
 
     /// <summary>
-    /// Gets the target framework of the package.
+    /// Gets the target framework of the project.
     /// </summary>
     public string TargetFramework { get; }
 
     /// <summary>
-    /// Gets the runtime identifier of the package (optional).
+    /// Gets the runtime identifier of the project (optional).
     /// </summary>
     public string? RuntimeIdentifier { get; }
 
@@ -41,9 +41,8 @@ public sealed class PackageDataReader : IPackageDataReader
     /// Initializes a new instance of the <see cref="PackageDataReader"/> class.
     /// </summary>
     /// <param name="assetsFilePath">The file path of the project assets file.</param>
-    /// <param name="targetFramework">The target framework of the package.</param>
-    /// <param name="runtimeIdentifier">The runtime identifier of the package (optional).</param>
-    /// <param name="knownPackageIds">Represents a collection of known package IDs and their associated owners or products (optional).</param>
+    /// <param name="targetFramework">The target framework of the project.</param>
+    /// <param name="runtimeIdentifier">The runtime identifier of the project (optional).</param>
     public PackageDataReader(string assetsFilePath, string targetFramework, string? runtimeIdentifier)
         : this(new AssetsFilePath(assetsFilePath), targetFramework, runtimeIdentifier)
     {
@@ -53,9 +52,8 @@ public PackageDataReader(string assetsFilePath, string targetFramework, string?
     /// Initializes a new instance of the <see cref="PackageDataReader"/> class.
     /// </summary>
     /// <param name="assetsFilePath">The file path of the project assets file.</param>
-    /// <param name="targetFramework">The target framework of the package.</param>
-    /// <param name="runtimeIdentifier">The runtime identifier of the package (optional).</param>
-    /// <param name="knownPackageIds">Represents a collection of known package IDs and their associated owners or products (optional).</param>
+    /// <param name="targetFramework">The target framework of the project.</param>
+    /// <param name="runtimeIdentifier">The runtime identifier of the project (optional).</param>
     public PackageDataReader(AssetsFilePath assetsFilePath, string targetFramework, string? runtimeIdentifier)
     {
         ThrowHelper.ThrowIfNullOrEmpty(targetFramework);
@@ -74,14 +72,16 @@ public IReadOnlyCollection<IPackageData> Read(CancellationToken cancellationToke
     {
         cancellationToken.ThrowIfCancellationRequested();
 
-        NuGetFramework framework = NuGetFramework.Parse(TargetFramework);
         LockFile lockFile = AssetsFilePath.ReadLockFile();
 
+        NuGetFramework framework = GetFramework(lockFile, TargetFramework)
+            ?? throw new InvalidOperationException($"No target framework was found for the alias '{TargetFramework}'.");
+
         IList<LibraryDependency> projectDependencies = lockFile.PackageSpec
             .GetTargetFramework(framework)
             .Dependencies;
 
-        LockFileTarget? target = TryGetTarget(lockFile, framework)
+        LockFileTarget? target = TryGetTarget(lockFile, framework, RuntimeIdentifier)
             ?? throw new InvalidOperationException($"No target was found for the target framework '{TargetFramework}' and the runtime id '{RuntimeIdentifier}'.");
 
         List<IPackageData> result = new();
@@ -121,11 +121,18 @@ public IReadOnlyCollection<IPackageData> Read(CancellationToken cancellationToke
 
         return result;
 
-        LockFileTarget TryGetTarget(LockFile lockFile, NuGetFramework framework)
+        static NuGetFramework? GetFramework(LockFile lockFile, string targetFramework)
+        {
+            return lockFile.PackageSpec.TargetFrameworks
+                .FirstOrDefault(tfi => tfi.TargetAlias.Equals(targetFramework, StringComparison.OrdinalIgnoreCase))
+                ?.FrameworkName;
+        }
+
+        static LockFileTarget TryGetTarget(LockFile lockFile, NuGetFramework framework, string? runtimeIdentifier)
         {
-            return string.IsNullOrEmpty(RuntimeIdentifier)
+            return string.IsNullOrEmpty(runtimeIdentifier)
                 ? lockFile.GetTarget(framework, null)
-                : lockFile.GetTarget(framework, RuntimeIdentifier)
+                : lockFile.GetTarget(framework, runtimeIdentifier)
                     ?? lockFile.GetTarget(framework, null);
         }
     }

src/PackScan.PackagesReader/PackageDataReader.cs

@@ -0,0 +1,29 @@
+using PackScan.PackagesProvider;
+
+namespace PackScan.Analyzer.Test;
+
+public class IntegrationTests
+{
+    [Fact]
+    public void Exists_Moq()
+    {
+        IPackage? package = Packages.GetPackageById("Moq");
+      
+        Assert.NotNull(package);
+        Assert.Same(package.Id, "Moq");
+        Assert.Equal(package.Version.Version, new Version(4, 18, 4));
+        Assert.True(package.IsProjectDependency);
+        Assert.Contains(package.DependencyPackages, p => p.Id == "Castle.Core");
+    }
+
+    [Fact]
+    public void Exists_Castle_Core()
+    {
+        IPackage? package = Packages.GetPackageById("Castle.Core");
+
+        Assert.NotNull(package);
+        Assert.Same(package.Id, "Castle.Core");
+        Assert.Equal(package.Version.Version, new Version(5, 1, 1));
+        Assert.False(package.IsProjectDependency);
+    }
+}

test/PackScan.Analyzer.Test/CoreTests.cs

@@ -1,38 +1,43 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
+  <!-- Analyzer -->
   <Import Project="..\..\src\PackScan.Analyzer\PackScan.Analyzer.props" />
   <Import Project="..\..\src\PackScan.Defaults\PackScan.Defaults.props" />
-  
+
+  <!-- Test project properties -->
   <PropertyGroup>
     <TargetFrameworks>netcoreapp3.1;net5.0;net6.0;net7.0</TargetFrameworks>
-    <EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles>
     <NoWarn>$(NoWarn);NETSDK1138</NoWarn>
     <IsTestProject>true</IsTestProject>
     <IsPackable>false</IsPackable>
+  </PropertyGroup>
 
+  <!-- Analyzer configuration -->
+  <PropertyGroup>
     <AllowEmptyLicenses>true</AllowEmptyLicenses>
     <AllowedLicensesAnalyzationEnabled>True</AllowedLicensesAnalyzationEnabled>
     <PackagesProviderLoadContentsParallel Condition="'$(Configuration)' == 'Debug'">False</PackagesProviderLoadContentsParallel>
   </PropertyGroup>
 
+    <!-- Global usings -->  
   <ItemGroup>
     <Using Include="Xunit" />
   </ItemGroup>
 
+    <!-- XUnit packages -->  
   <ItemGroup>
     <PackageReference Include="xunit" Version="2.5.0" />
     <PackageReference Include="xunit.core" Version="2.5.0" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.5" PrivateAssets="all" />
-
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.5.0" />
-    <PackageReference Include="coverlet.collector" Version="3.2.0" PrivateAssets="all" />
   </ItemGroup>
 
+  <!-- Test packages -->
   <ItemGroup>
-    <!-- Test packages -->
     <PackageReference Include="Moq" Version="[4.18.4]" />
   </ItemGroup>
 
+  <!-- Analyzer -->
   <ItemGroup>
     <ProjectReference Include="..\..\src\PackScan.Analyzer\PackScan.Analyzer.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
     <ProjectReference Include="..\..\src\PackScan.PackagesProvider.Abstractions\PackScan.PackagesProvider.Abstractions.csproj" />