Merge pull request #91 from rbetjes/fix_undefined_exception

fix for #89: prevent read attribute from undefined caused by info being empty array on error

Author: dhmlau

lib/dashdb.js

@@ -83,7 +83,7 @@ DASHDB.prototype.update = function(model, where, data, options, cb) {
   sql.merge(new ParameterizedSQL(')'));
   self.execute(sql.sql, stmt.params, options, function(err, info) {
     if (cb) {
-      cb(err, {count: parseInt(info[0].affectedRows)});
+      cb(err, {count: parseInt(info[0] ? info[0].affectedRows : 0)});
     }
   });
 };

test/dashdb.dml.test.js

@@ -0,0 +1,57 @@
+// Copyright IBM Corp. 2019. All Rights Reserved.
+// Node module: loopback-connector-dashdb
+// This file is licensed under the Artistic License 2.0.
+// License text available at https://opensource.org/licenses/Artistic-2.0
+
+'use strict';
+
+/* eslint-env node, mocha */
+process.env.NODE_ENV = 'test';
+
+require('should');
+
+let db, FloatingPoint;
+
+describe('dml', function() {
+  before(function() {
+    require('./init.js');
+  });
+
+  describe('insert and patch', function() {
+    before(function(done) {
+      db = global.getDataSource();
+
+      FloatingPoint = db.define('FLOATING_POINT', {
+        id: {type: String, length: 20, index: true},
+        aFloat: {type: Number, dashdb: {dataType: 'double'}},
+      });
+      db.automigrate('FLOATING_POINT', done);
+    });
+
+    // Return an async function create a record in floating_point table
+    function createRecInFP(rec) {
+      return function(done) {
+        FloatingPoint.create(rec,
+          function(err, p) {
+            if (err) {
+              done(err);
+            } else {
+              done();
+            }
+          });
+      };
+    }
+
+    describe('patch', function() {
+      const rec = {aFloat: 42.234567};
+      before(createRecInFP(rec));
+
+      it('should fail with a specific SQL error', async function() {
+        await FloatingPoint.updateAll(rec, {aFloat: 42.234567890123456789})
+          .should.be.rejectedWith(
+            '[IBM][CLI Driver] CLI0135E  Invalid scale value. SQLSTATE=HY094',
+          );
+      });
+    });
+  });
+});

test/table.template

@@ -74,3 +74,8 @@
 	"UID" VARCHAR(1024),
 	"TTL" INT
    ) ORGANIZE BY ROW;
+
+   CREATE TABLE "?"."FLOATING_POINT"
+   (  "ID" VARCHAR(20) NOT NULL,
+   "A_FLOAT" DOUBLE
+   ) ORGANIZE BY ROW;