ci: update environment#63
Open
achrinza wants to merge 1 commit into
Open
Conversation
- test against Node.js v16,v17,v18 - test against Redis v7 - test against alternate architectures see: loopbackio/cicd#2 see: loopbackio/cicd#27 Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com>
dhmlau
approved these changes
May 28, 2022
Member
dhmlau
left a comment
dhmlau
left a comment
There was a problem hiding this comment.
LGTM. We might want to add the code linter and commit linter as well. But I'm good to leave it for a separate PR. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see: loopbackio/cicd#2
see: loopbackio/cicd#27
Signed-off-by: Rifa Achrinza 25147899+achrinza@users.noreply.github.com
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machine