Fix: Connection terminated unexpectedly error not caught in on error listener#781
Closed
rchandranmani wants to merge 11 commits intoloopbackio:masterfrom
rchandranmani:master
Closed
Fix: Connection terminated unexpectedly error not caught in on error listener#781rchandranmani wants to merge 11 commits intoloopbackio:masterfrom rchandranmani:master
rchandranmani wants to merge 11 commits intoloopbackio:masterfrom
rchandranmani:master
Conversation
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ramachandran Mani <m.chandru.m@gmail.com>
Signed-off-by: Ramachandran Mani <m.chandru.m@gmail.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Ramachandran Mani <m.chandru.m@gmail.com>
Contributor
|
Hi, @rchandranmani. Can you please fix the linting issues and the commit message? You'd also need to add some tests around the changes you've made. |
Added unit tests for the attachErrorHandler function in postgresql.js to ensure correct error handler attachment behavior. Introduced the 'rewire' dev dependency for testing private functions and added a 'lint-fix' npm script for convenience.
…listener Signed-off-by: Ramachandran Mani <m.chandru.m@gmail.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Added unit tests for the attachErrorHandler function in postgresql.js to ensure correct error handler attachment behavior. Introduced the 'rewire' dev dependency for testing private functions and added a 'lint-fix' npm script for convenience. Signed-off-by: Ramachandran Mani <m.chandru.m@gmail.com>
Contributor
Author
|
This branch is messed up. Creating a new PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our application was crashing when the database connection unexpectedly failed. This happened because:
removeAllListeners('error'), which unintentionally removed the pg library's error handlers.We've fixed this by:
removeAllListeners('error')call within the connector. This ensures that the pg library's built-in error handling for connection issues remains active.(!pg.listenerCount('error')). This prevents us from creating too many listeners (addressing past MaxEventListeners warnings) while ensuring all critical connection errors are still properly managed.Fixes #778
See also #746
Checklist
npm testpasses on your machine