fix: Connection terminated unexpectedly error not caught in on error handler#783
Merged
dhmlau merged 1 commit intoloopbackio:masterfrom Jul 17, 2025
Conversation
Contributor
Author
|
@aaqilniz Can you take a look now. |
7aabec6 to
0ba53be
Compare
Signed-off-by: Ramachandran Mani <ramachandranm@pnp-hcl.com>
0ba53be to
8e2863d
Compare
Contributor
Author
|
@aaqilniz fixed the commit casing |
Contributor
Author
|
Hi @dhmlau - Could you please take a look at this PR. |
dhmlau
approved these changes
Jul 14, 2025
Member
dhmlau
left a comment
There was a problem hiding this comment.
@rchandranmani, thanks for your contribution. It LGTM. 👍
Member
|
@rchandranmani, thanks again for your contribution. Your PR has landed! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our application was crashing when the database connection unexpectedly failed. This happened because:
We've fixed this by:
Unit tests have been added for coverage;
rewire(dev dependency) was used to avoid exporting functions solely for testing.A new lint-fix command has also been introduced to address linting issues.
Fixes #778
See also #746
Checklist
npm testpasses on your machine