Skip to content

Commit 28dec15

Browse files
samarpanBdhmlau
authored andcommitted
fix: rebiew comments
Signed-off-by: Samarpan Bhattacharya <this.is.samy@gmail.com>
1 parent 7a02f12 commit 28dec15

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

lib/sql.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -562,7 +562,7 @@ SQLConnector.prototype.buildInsertAll = function(model, data, options) {
562562
return null;
563563
}
564564
const fieldsArray = this.buildFieldsFromArray(model, data);
565-
if (fieldsArray.length === 0) {
565+
if (Array.isArray(fieldsArray) && fieldsArray.length === 0) {
566566
debug('no fields found for insert query');
567567
// return immediately if no fields found
568568
return null;
@@ -1269,7 +1269,7 @@ SQLConnector.prototype.buildFields = function(model, data, excludeIds) {
12691269
*/
12701270
SQLConnector.prototype.buildFieldsFromArray = function(model, data, excludeIds) {
12711271
const fields = [];
1272-
if (data.length > 0) {
1272+
if (Array.isArray(data) && data.length > 0) {
12731273
const keys = Object.keys(data[0]);
12741274
for (let i = 0; i < data.length; i++) {
12751275
fields.push(this._buildFieldsForKeys(model, data[i], keys, excludeIds));

0 commit comments

Comments
 (0)