send_notification to multiple users

[cecilialau6776]

I would like the ability to [easily] send notifications to multiple users at once (such as by specifying a QuerySet or other iterable a recipients parameter in send_notification. Of course, I could simply wrap send_notification in a for loop, but that's not very efficient. Any plans to support this? I could submit a pull request.

[kevinrenskers]

Of course, I could simply wrap send_notification in a for loop, but that's not very efficient.

Isn't it? A version of send_notification that takes a QuerySet or iterable would basically do the same, right?

At this moment I think it makes sense to keep the library tight, with one way to send a notification. You can call this method any way you like, from a loop or a generator or whatever else you want.

Even if we'd add a bulk method to the library, things like channel.process() are still executed per-notification so there's no big performance wins either. Yes we could use bulk_create in one or two places, but other bottlenecks remain.

Are you running into actual efficiency problems or is this just a hypothetical question?

[cecilialau6776]

I'm not running into actual efficiency problems - it would just be convenient and I figure that it would be easy to add/support.

[kevinrenskers]

True, it would be pretty easy - internally it would simply do a loop, at least for a first basic version of this feature.

If you'd like to submit a pull request, that would be great. I think a sibling function called send_notifications would be best.

[kevinrenskers]

Closed by #25