Skip to content

Add send_notifications() util function#25

Merged
kevinrenskers merged 3 commits into
loopwerk:developfrom
cecilialau6776:send_notifications
May 14, 2026
Merged

Add send_notifications() util function#25
kevinrenskers merged 3 commits into
loopwerk:developfrom
cecilialau6776:send_notifications

Conversation

@cecilialau6776

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread generic_notifications/__init__.py Outdated
**kwargs,
):
"""
Send notifications multiple users through all registered channels.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Send notifications multiple users through all registered channels.
Send notifications to multiple users through all registered channels.

Comment thread generic_notifications/__init__.py Outdated
Comment thread generic_notifications/__init__.py Outdated
Comment thread tests/test_utils.py Outdated

@kevinrenskers kevinrenskers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, just a few small improvements please

@cecilialau6776

Copy link
Copy Markdown
Contributor Author

Updated to return success count from send_notifications(). While I'm here, I could also change some of the tests in test_utils.py - several of them import NotificationChannel in the test.

@kevinrenskers kevinrenskers changed the base branch from main to develop May 14, 2026 16:01
@kevinrenskers

Copy link
Copy Markdown
Member

I can do that in a separate commit, leaving the PR smaller in focus. Thanks though.

@kevinrenskers kevinrenskers merged commit 77b4471 into loopwerk:develop May 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants