Skip to content

Commit 10b79aa

Browse files
committed
add comment clarifying srid reqs
1 parent 12c1bf6 commit 10b79aa

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

kernel/src/schema/mod.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1560,6 +1560,8 @@ impl GeometryType {
15601560
///
15611561
/// Returns `Err` if `srid` is empty.
15621562
pub fn try_new(srid: &str) -> DeltaResult<Self> {
1563+
// We only check that the SRID is non-empty; validating the value against the full set
1564+
// of (1000+) recognized SRIDs is future work.
15631565
if srid.is_empty() {
15641566
return Err(Error::invalid_geometry("SRID cannot be empty"));
15651567
}
@@ -1604,6 +1606,8 @@ impl GeographyType {
16041606
srid: Option<&str>,
16051607
algorithm: Option<EdgeInterpolationAlgorithm>,
16061608
) -> DeltaResult<Self> {
1609+
// We only check that the SRID is non-empty; validating the value against the full set
1610+
// of (1000+) recognized SRIDs is future work.
16071611
let srid = match srid {
16081612
None => DEFAULT_GEO_SRID.to_string(),
16091613
Some(s) => {

0 commit comments

Comments
 (0)