Testing ci with feature#3
Open
lorenarosati wants to merge 19 commits into
Open
Conversation
re create functionality of criterion compare action
Owner
Author
|
/bench --tags listing-optimization |
|
PR title does not match the required pattern. Please ensure you follow the conventional commits spec. Your title should start with Title: Your title should start with Title: Your title should start with Title: Your title should start with Title: |
add list with backward checkpoint scan added tests, some restructuring fixes fix restored list() tests for reviewer readability quick fix quick fix fix final tests test fixes fix
git checkout -- <name> treats the argument as a pathspec, not a branch name, causing "pathspec did not match" errors. Using FETCH_HEAD avoids passing any user-controlled input to the checkout command entirely.
lorenarosati
force-pushed
the
testing-ci-with-feature
branch
from
20f0d5c to
b55bee6
Compare
Owner
Author
|
/bench --tags listing-optimization |
The post-comment job runs on a fresh runner with no checkout, so gh cannot auto-detect the repository from git. Pass --repo explicitly.
Owner
Author
|
/bench --tags listing-optimization |
Benchmark for c651b7dClick to view benchmark
|
Owner
Author
|
/bench |
1 similar comment
Owner
Author
|
/bench |
Owner
Author
|
/bench --filter snapshotConstruction |
Owner
Author
|
/bench --tags base --filter 101kAdds.*snapshotConstruction |
Owner
Author
|
/bench |
Owner
Author
|
/bench --filter snapshotConstruction |
Owner
Author
|
/bench --tags base --filter 101kAdds.*snapshotConstruction |
Owner
Author
|
/bench --filter 101kAdds|10kAdds |
Owner
Author
|
/bench --tags listing-optimization,metadata-only |
Owner
Author
|
/bench --tags metadata-only, listing-optimization |
Benchmark for 7a7215atags: `base`
|
Benchmark for 7a7215atags: `listing-optimization,metadata-only`
|
Owner
Author
|
/bench --filter 101kAdds|10kAdds |
Owner
Author
|
/bench --tags metadata-only, listing-optimization |
Owner
Author
|
/bench --filter snapshotConstruction |
Owner
Author
|
/bench --filter snapshot |
Owner
Author
|
/bench --filter 101kAdds|10kAdds |
Owner
Author
|
/bench --tags listing-optimization, base |
Owner
Author
|
/bench --tags base --filter 101kAdds.*snapshotConstruction |
Benchmark for 7a7215atags: `listing-optimization,`
|
Benchmark for 7a7215atags: `base` | filter: `101kAdds.*snapshotConstruction`
|
Benchmark for 7a7215afilter: `101kAdds|10kAdds`
|
Benchmark for 7a7215afilter: `snapshot`
|
Owner
Author
|
/bench --tags crc-optimization --filter SinceCrc.*snapshotConstruction |
Benchmark for 47d1fb2tags: `crc-optimization` | filter: `SinceCrc.*snapshotConstruction`
|
Owner
Author
|
/bench --tags listing-optimization, base |
Owner
Author
|
/bench --tags listing-optimization |
Benchmark for 47d1fb2tags: `listing-optimization`
|
github-merge-queue Bot
pushed a commit
to delta-io/delta-kernel-rs
that referenced
this pull request
Apr 1, 2026
…action (#2264) ## What changes are proposed in this pull request? This PR introduces the following functionality: - Replaces the boa-dev/criterion-compare-action GitHub Action with a custom bash script (.github/scripts/run-benchmarks.sh) that replicates its output format, including a markdown table with base and PR durations, a percentage change column, and bolding of the faster result when the difference is statistically significant based on Criterion's error bounds. - Splits the benchmark workflow into two jobs — run-benchmark (which checks out and runs untrusted PR code with only contents: read permission) and post-comment (which holds pull-requests: write and posts results) — so that GH_TOKEN is never in the environment when untrusted code executes. - Extends the /bench comment syntax to support both a --tags flag (comma-separated list passed as BENCH_TAGS) and a --filter flag (Criterion benchmark name regex), where bare /bench defaults to --tags base. - Pins all GitHub Actions to full commit SHAs and passes all user-controlled values through environment variables rather than inline expressions to prevent expression injection. ## How was this change tested? Made a pull request on my fork and checked that it commented correctly and that --tags and --filter work: lorenarosati#3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
How was this change tested?