handling of various nullable

Author: lorenzomaiuri-dev

CodiceFiscale/helpers/CodeExtractorsHelper.cs

@@ -24,7 +24,7 @@ public static string ExtractConsonantsAndVowels(List<char> consonants, List<char
     }
 
     // Method to get a date from string or datetime
-    public static DateTime? ExtractDate(object date, string separator = "-")
+    public static DateTime? ExtractDate(object? date, string separator = "-")
     {
         if (date == null)
         {
@@ -36,8 +36,8 @@ public static string ExtractConsonantsAndVowels(List<char> consonants, List<char
             return ((DateTime)date).ToUniversalTime();
         }
 
-        var dateString = date.ToString();
-        var dateSlug = StringsHelper.Slugify(dateString);
+        string dateString = date.ToString();
+        string dateSlug = StringsHelper.Slugify(dateString);
 
         // Split the date
         var dateParts = dateSlug.Split(separator.ToCharArray(), StringSplitOptions.RemoveEmptyEntries);
@@ -68,14 +68,14 @@ public static string ExtractConsonantsAndVowels(List<char> consonants, List<char
     }
 
     // Method to find the birthplace
-    public static List<Dictionary<string, object>> ExtractBirthplace(string birthplace, object birthdate = null)
+    public static List<Dictionary<string, object>>? ExtractBirthplace(string birthplace, object? birthdate = null)
     {
         // slugify the birthplace
         var tmpBirthplaceSlug = StringsHelper.Slugify(birthplace);
 
         // if it's a alphanumeric code it must be uppercase, if it's a place name it must be lowercase
         var birthplaceSlug = (StringsHelper.IsAlphaNumeric(tmpBirthplaceSlug)) ? tmpBirthplaceSlug.ToUpper() : tmpBirthplaceSlug.ToLower();
-        List<Dictionary<string, object>> birthplacesOptions = null;
+        List<Dictionary<string, object>>? birthplacesOptions = null;
 
         // Check if the slug of the birthplace is in the data
         if (DataHelper.INDEXED_DATA["municipalities"].ContainsKey(birthplaceSlug))

CodiceFiscale/helpers/DataHelper.cs

@@ -20,7 +20,12 @@ public static T GetData<T>(string filename)
    	{
 		string filePath = Path.Combine(GetDataBaseDir(), "data", filename);
 		string jsonContent = File.ReadAllText(filePath);
-		return JsonSerializer.Deserialize<T>(jsonContent);
+		T? serializedData = JsonSerializer.Deserialize<T>(jsonContent);
+		if (serializedData == null)
+		{
+			throw new InvalidOperationException($"Failed to deserialize JSON file: {filename}");
+		}
+		return serializedData;
 	}
 
    	// Returns municipalities data (municipalities.json)

CodiceFiscale/helpers/StringsHelper.cs

@@ -15,6 +15,10 @@ public static bool IsAlphaNumeric(string s)
     // Method to slugify a string
     public static string Slugify(string input)
     {
+        if (input == null)
+        {
+            return "";
+        }
         return Regex.Replace(input.ToLower(), @"\s+", "-");
     }
 }

CodiceFiscale/models/Country.cs

@@ -5,18 +5,18 @@ namespace CodiceFiscaleLib.Models;
 public class Country
 {
    [JsonPropertyName("code")]
-   public string Code { get; set; }
+   public string? Code { get; set; }
 
    [JsonPropertyName("name_slugs")]
-   public List<string> NameSlugs { get; set; }
+   public List<string>? NameSlugs { get; set; }
 
    // Convert the class to a dictionary
    public Dictionary<string, object> ToDictionary()
    {
    	return new Dictionary<string, object>()
    	{
-       	{ "code", Code },
-       	{ "name_slugs", NameSlugs }
+         { "code", Code ?? string.Empty },
+         { "name_slugs", NameSlugs ?? new List<string>() }
    	};
    }
 }

CodiceFiscale/models/Municipality.cs

@@ -5,22 +5,22 @@ namespace CodiceFiscaleLib.Models;
 public class Municipality
 {
    [JsonPropertyName("code")]
-   public string Code { get; set; }
+   public string? Code { get; set; }
 
    [JsonPropertyName("province")]
-   public string Province { get; set; }
+   public string? Province { get; set; }
 
    [JsonPropertyName("name_slugs")]
-   public List<string> NameSlugs { get; set; }
+   public List<string>? NameSlugs { get; set; }
 
    // Convert the class to a dictionary
    public Dictionary<string, object> ToDictionary()
    {
    	return new Dictionary<string, object>()
    	{
-       	{ "code", Code },
-       	{ "province", Province },
-       	{ "name_slugs", NameSlugs }
+         { "code", Code ?? string.Empty },
+         { "province", Province ?? string.Empty },
+         { "name_slugs", NameSlugs ?? new List<string>() }
    	};
    }
 }