Merge pull request #777 from loro-dev/fix-c-warnings

chore: fix clippy warnings

Author: zxch3n

crates/delta/src/delta_rope.rs

@@ -213,7 +213,7 @@ impl<V: DeltaValue, Attr: DeltaAttr> DeltaRope<V, Attr> {
     /// - You can peek the next item.
     ///
     /// It's useful to implement algorithms related to Delta
-    pub fn iter_with_len(&self) -> Iter<V, Attr> {
+    pub fn iter_with_len(&self) -> Iter<'_, V, Attr> {
         Iter::new(self)
     }
 

crates/kv-store/src/sstable.rs

@@ -325,7 +325,7 @@ impl SsTable {
         self.data.clone()
     }
 
-    pub fn iter(&self) -> SsTableIter {
+    pub fn iter(&self) -> SsTableIter<'_> {
         SsTableIter::new(self)
     }
 

crates/loro-internal/src/arena.rs

@@ -133,7 +133,7 @@ impl SharedArena {
         f(&mut guards);
     }
 
-    fn get_arena_guards(&self) -> ArenaGuards {
+    fn get_arena_guards(&self) -> ArenaGuards<'_> {
         ArenaGuards {
             container_id_to_idx: self.inner.container_id_to_idx.lock().unwrap(),
             container_idx_to_id: self.inner.container_idx_to_id.lock().unwrap(),

crates/loro-internal/src/container/tree/bool_rle_vec.rs

@@ -113,7 +113,7 @@ impl BoolRleVec {
         self.len == 0
     }
 
-    pub fn iter(&self) -> BoolRleVecIter {
+    pub fn iter(&self) -> BoolRleVecIter<'_> {
         BoolRleVecIter {
             rle_vec: self,
             index: 0,

crates/loro-internal/src/dag.rs

@@ -197,6 +197,7 @@ impl<T: Dag + ?Sized> DagUtils for T {
     }
 }
 
+#[allow(dead_code)]
 fn get_version_vector<'a, Get, D>(get: &'a Get, id: ID) -> VersionVector
 where
     Get: Fn(ID) -> Option<D>,

crates/loro-internal/src/dag/iter.rs

@@ -22,6 +22,7 @@ impl Ord for IdHeapItem {
     }
 }
 
+#[allow(dead_code)]
 pub(crate) fn iter_dag_with_vv<T, D: Dag<Node = T>>(dag: &D) -> DagIteratorVV<'_, T> {
     DagIteratorVV {
         dag,
@@ -30,6 +31,7 @@ pub(crate) fn iter_dag_with_vv<T, D: Dag<Node = T>>(dag: &D) -> DagIteratorVV<'_
     }
 }
 
+#[allow(dead_code)]
 pub(crate) fn iter_dag<T>(dag: &dyn Dag<Node = T>) -> DagIterator<'_, T> {
     DagIterator {
         dag,

crates/loro-internal/src/dag/mermaid.rs

@@ -1,4 +1,5 @@
 use super::*;
+#[allow(dead_code)]
 struct BreakPoints {
     break_points: FxHashMap<PeerID, FxHashSet<Counter>>,
     /// start ID to ID. The target ID may be in the middle of an op.
@@ -7,6 +8,7 @@ struct BreakPoints {
     links: FxHashMap<ID, Vec<ID>>,
 }
 
+#[allow(dead_code)]
 struct Output {
     clients: FxHashMap<PeerID, Vec<IdSpan>>,
     /// start ID to start ID.
@@ -15,6 +17,7 @@ struct Output {
     links: FxHashMap<ID, Vec<ID>>,
 }
 
+#[allow(dead_code)]
 fn to_str(output: Output) -> String {
     let mut s = String::new();
     let mut indent_level = 0;
@@ -70,6 +73,7 @@ fn to_str(output: Output) -> String {
     s
 }
 
+#[allow(dead_code)]
 fn break_points_to_output(input: BreakPoints) -> Output {
     let mut output = Output {
         clients: FxHashMap::default(),
@@ -112,6 +116,7 @@ fn break_points_to_output(input: BreakPoints) -> Output {
     output
 }
 
+#[allow(dead_code)]
 fn get_dag_break_points<T: DagNode>(dag: &impl Dag<Node = T>) -> BreakPoints {
     let mut break_points = BreakPoints {
         break_points: FxHashMap::default(),
@@ -140,6 +145,7 @@ fn get_dag_break_points<T: DagNode>(dag: &impl Dag<Node = T>) -> BreakPoints {
     break_points
 }
 
+#[allow(dead_code)]
 pub(crate) fn dag_to_mermaid<T: DagNode>(dag: &impl Dag<Node = T>) -> String {
     to_str(break_points_to_output(get_dag_break_points(dag)))
 }

crates/loro-internal/src/delta/map.rs

@@ -79,6 +79,7 @@ impl<T> MapDiff<T> {
 }
 
 #[derive(Clone, Debug, Serialize)]
+#[allow(dead_code)]
 pub struct MapDiffRaw<T> {
     pub(crate) added: FxHashMap<InternalString, T>,
     pub(crate) deleted: FxHashSet<InternalString>,

crates/loro-internal/src/encoding.rs

@@ -377,7 +377,7 @@ const MIN_HEADER_SIZE: usize = 22;
 pub(crate) fn parse_header_and_body(
     bytes: &[u8],
     check_checksum: bool,
-) -> Result<ParsedHeaderAndBody, LoroError> {
+) -> Result<ParsedHeaderAndBody<'_>, LoroError> {
     let reader = &bytes;
     if bytes.len() < MIN_HEADER_SIZE {
         return Err(LoroError::DecodeError("Invalid import data".into()));

crates/loro-internal/src/encoding/arena.rs

@@ -129,7 +129,7 @@ impl ValueDecodedArenasTrait for DecodedArenas<'_> {
     }
 }
 
-pub fn decode_arena(bytes: &[u8]) -> LoroResult<DecodedArenas> {
+pub fn decode_arena(bytes: &[u8]) -> LoroResult<DecodedArenas<'_>> {
     let arenas = EncodedArenas::decode_arenas(bytes)?;
     Ok(DecodedArenas {
         peer_ids: PeerIdArena::decode(arenas.peer_id_arena)?,
@@ -174,7 +174,7 @@ impl EncodedArenas<'_> {
         ans
     }
 
-    fn decode_arenas(bytes: &[u8]) -> LoroResult<EncodedArenas> {
+    fn decode_arenas(bytes: &[u8]) -> LoroResult<EncodedArenas<'_>> {
         let (peer_id_arena, rest) = read_arena(bytes)?;
         let (container_arena, rest) = read_arena(rest)?;
         let (key_arena, rest) = read_arena(rest)?;