Skip to content

Commit 59d9c2f

Browse files
AlexJones0machshev
authored andcommitted
fix: status shown for combined instrumentation jobs
An accidental omission of the intended `omit_status=True` keyword argument meant that for visualizations of the longest tests, where many jobs are combined into a single bar (for performance reasons), the status of the shortest such job was always being reported, instead of not reporting any status like was intended (since there could be variation amongst the combined jobs). Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
1 parent 0f13466 commit 59d9c2f

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/dvsim/instrumentation/report/longest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ def _make_combined_bar_info(
261261
f"Mean duration: {format_time_metric(avg_duration)}",
262262
f"Minimum duration: {format_time_metric(min_duration)}",
263263
]
264-
hover = make_job_metadata_hover(test.name, extra_timing_info, meta)
264+
hover = make_job_metadata_hover(test.name, extra_timing_info, meta, omit_status=True)
265265

266266
return total_duration, hover
267267

0 commit comments

Comments
 (0)