docs: Improve documentation comment for testplan.Element.has_tags#217
Merged
Conversation
AlexJones0
approved these changes
May 21, 2026
| Tags may be preceded with `-` to exclude the testpoints that contain | ||
| that tag. | ||
| The element should match every item in the set of tags. If one of these | ||
| elements is preceded with "-", the meaning is negated (so the element |
Contributor
There was a problem hiding this comment.
I think this might be intended to be:
Suggested change
| elements is preceded with "-", the meaning is negated (so the element | |
| tags is preceded with "-", the meaning is negated (so the element |
(or "items" also makes sense in the given context)
This was partly motivated by the fact I couldn't immediately see whether the test was an AND or an OR. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was partly motivated by the fact I couldn't immediately see whether the test was an AND or an OR.