[cheriot,rtl] Add TRVK filter to Ibex sources#2455
Draft
thommythomaso wants to merge 2 commits into
Draft
Conversation
The `stream_fork` and `stream_join` modules are used in some CHERIoT memory IPs. Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
thommythomaso
added a commit
to thommythomaso/opentitan-tbenz-pub
that referenced
this pull request
Jun 30, 2026
This commit updates the vendored ibex to `thommythomaso/ibex-tbenz-pub`. This has to be updated to point to `lowrisc/ibex` as soon as lowRISC/ibex#2455 and lowRISC/ibex#2456 are merged. Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
1 task
thommythomaso
added a commit
to thommythomaso/opentitan-tbenz-pub
that referenced
this pull request
Jun 30, 2026
This commit updates the vendored ibex to `thommythomaso/ibex-tbenz-pub`. This has to be updated to point to `lowrisc/ibex` as soon as lowRISC/ibex#2455 and lowRISC/ibex#2456 are merged. Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
20 tasks
andreaskurth
reviewed
Jul 3, 2026
| - rtl/ibex_register_file_ff.sv # generic FF-based | ||
| - rtl/ibex_register_file_fpga.sv # FPGA | ||
| - rtl/ibex_register_file_latch.sv # ASIC | ||
| - rtl/ibex_trvk.sv |
Contributor
There was a problem hiding this comment.
Adding ibex_trvk.sv to files_rtl here pulls in stream_fork / stream_join_dynamic, but ibex_top.core does not declare a dependency on the vendored common_cells core. The files_rtl.depend block above lists no pulp-platform:common_cells:common_cells, and no other .core file depends on it either — so fusesoc will not include those sources and ibex_top elaboration/lint will fail on unresolved stream_fork/stream_join_dynamic.
Please add it to files_rtl.depend:
- pulp-platform:common_cells:common_cells
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.