[bazel] Prepare for downstream sku configuration#30146
Merged
Merged
Conversation
cfrantz
commented
May 18, 2026
pamaury
approved these changes
Jun 22, 2026
cfrantz
force-pushed
the
sku-extra
branch
2 times, most recently
from
939cf8d to
bd1f0d3
Compare
sasdf
approved these changes
Jun 24, 2026
| "presign_perso": { | ||
| "repoRuleId": "@@bazel_tools//tools/build_defs/repo:http.bzl%http_archive", | ||
| "attributes": { | ||
| "url": "https://github.com/pamaury/ot-sku/releases/download/TEST_RELEASE_2/presign_perso.tar.xz", |
Contributor
There was a problem hiding this comment.
That's a good catch, it's weird that the build system did not catch this because it looks like the lock file is not clean?
Contributor
Author
There was a problem hiding this comment.
I re-generated the MODULE.bazel.lock which eliminated these downstream repos.
Allow `offline_signature_attach` to accept files provided by `DefaultInfo`. This allows the rule to accept `srcs` that are provided by a filegroup in addition to files provied by `presigning_artifacts`. Signed-off-by: Chris Frantz <cfrantz@google.com>
Make the perso mannifest publicly visible so downstream build rules can refer to it. Signed-off-by: Chris Frantz <cfrantz@google.com>
Signed-off-by: Amaury Pouly <amaury.pouly@opentitan.org>
Contributor
Author
|
I believe I have our downstream repo updated to support this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse an extra json file with http_archive or local_repository args. Instantiate those repos and symlink
offline_signature_attachto accept DefaultInfo.