[crypto] ML-DSA-87: Computation of the S and T vectors (5-6/8)#30164
Merged
andrea-caforio merged 3 commits intoMay 21, 2026
Conversation
nasahlpa
approved these changes
May 21, 2026
nasahlpa
left a comment
Contributor
There was a problem hiding this comment.
Thanks Andi, the implementation looks very clean :-)
A new routine is introduced to sample the S{1,2} vectors of the secret
key.
Signed-off-by: Andrea Caforio <andrea.caforio@lowrisc.org>
Signed-off-by: Andrea Caforio <andrea.caforio@lowrisc.org>
Signed-off-by: Andrea Caforio <andrea.caforio@lowrisc.org>
4fe3e74 to
23fbf9f
Compare
etterli
approved these changes
May 21, 2026
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The S and T vectors make up most of the public and secret key.
This is a series of PRs that in their composition result in FIPS-204-compliant OTBN implementation of ML-DSA-87 keygen.
Resources
Gadgets
[crypto] ML-DSA-87: Modulo 5 gadget (1/8) #30108sec_mod5Sampling
[crypto] ML-DSA-87: Rejection-sample coefficient-bounded polys (2/8) #30138sample_uniform_eta,expand_sEncoding
[crypto] ML-DSA-87: Encoding and rounding of T polynomials #30154encode_t0,encode_t1,power2round[crypto] ML-DSA-87: Encoding of S polynomials (4/8) #30162encode_sVector Ops
compute_tsample_shash_seed,hask_pkEpilogue
app