ci: consider PR review approvals and commit time in check-pr-changes-allowed.py#30178
Closed
sanjay-nagesh wants to merge 1 commit into
Closed
ci: consider PR review approvals and commit time in check-pr-changes-allowed.py#30178sanjay-nagesh wants to merge 1 commit into
sanjay-nagesh wants to merge 1 commit into
Conversation
…allowed.py Signed-off-by: Sanjay Nagesh <sanjaynagesh55@outlook.com>
Contributor
|
I'm not sure that we'll consider a PR from an unknown external contributor that adds tests to an internal bit of (boring) plumbing. If you're sure this is worth talking about, please re-open and explain why it matters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates "check-pr-changes-allowed.py" to use the GitHub Reviews API and the PR’s latest commit time when deciding whether blocked file changes are authorized. The script now reads issue comments and APPROVED reviews and accepts CHANGE AUTHORIZED: only if submitted after the last commit, fixing a bug where approvals made via the review UI were ignored