[bazel] Prepare for downstream sku configuration, modified version#30268
Draft
pamaury wants to merge 3 commits into
Draft
[bazel] Prepare for downstream sku configuration, modified version#30268pamaury wants to merge 3 commits into
pamaury wants to merge 3 commits into
Conversation
pamaury
force-pushed
the
sku-extra
branch
2 times, most recently
from
df6b028 to
f2c00f9
Compare
cfrantz
reviewed
Jun 3, 2026
Comment on lines
+366
to
+369
| provisioning_exts_exta = use_extension("@ot_provisioning_exts//:extension.bzl", "extra") | ||
| # We always import the provisioning_exts_extra repository so that it can be refered to by | ||
| # the provisioning_exts repo defined below. | ||
| use_repo(provisioning_exts_exta, "provisioning_exts_extra") |
Contributor
There was a problem hiding this comment.
Is extension.bzl missing from this PR?
also spelling nit: exta
Contributor
Author
There was a problem hiding this comment.
You are correct, I added the file and fixed the typo
pamaury
force-pushed
the
sku-extra
branch
5 times, most recently
from
195379a to
bdf7304
Compare
pamaury
commented
Jun 9, 2026
| load("@bazel_tools//tools/build_defs/repo:local.bzl", "local_repository") | ||
|
|
||
| def _extra_repo_impl(rctx): | ||
| # This is basically a reimplementation of local_repository but doing |
Contributor
Author
There was a problem hiding this comment.
@cfrantz I had to change my implementation from local_repository to this, otherwise bazel ends up putting an absolute path in the lock file which depends on the user so I used a workaround. This seems related to bazelbuild/bazel#18936
pamaury
force-pushed
the
sku-extra
branch
4 times, most recently
from
5ab5968 to
4a748f8
Compare
Allow `offline_signature_attach` to accept files provided by `DefaultInfo`. This allows the rule to accept `srcs` that are provided by a filegroup in addition to files provied by `presigning_artifacts`. Signed-off-by: Chris Frantz <cfrantz@google.com>
Make the perso mannifest publicly visible so downstream build rules can refer to it. Signed-off-by: Chris Frantz <cfrantz@google.com>
Signed-off-by: Amaury Pouly <amaury.pouly@opentitan.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #30146 which uses the module + injected repo strategy explained in lowRISC/ot-sku#5. TODO: explain more here