Otsca test#398
Merged
Merged
Conversation
siemen11
requested review from
andrea-caforio,
nasahlpa and
vogelpi
as code owners
nasahlpa
reviewed
Jul 21, 2025
Collaborator
There was a problem hiding this comment.
Thanks Siemen for working this, having a test framework for ot-sca <-> pentest framework does have a huge impact on the maintainability of the pentesting infrastructure :)
I've dropped a couple of comments. It seems that your changes broke the current SCA capture scripts (please see the CI). In order to merge this we would need to make sure that they still work.
nasahlpa
reviewed
Jul 21, 2025
nasahlpa
reviewed
Jul 22, 2025
Collaborator
nasahlpa
left a comment
nasahlpa
left a comment
There was a problem hiding this comment.
Thanks Siemen. I'd suggest a couple of points before we can merge this:
- Can you please rebase the PR such that we see that CI passes?
- Would it be possible to add a very brief documentation to
test/penetrationtests, i.e., a brief how to run this? - Could you please squash some of the commits? E.g., creating a new communication folder and then moving it again at the end?
- Would it be possible to move the default configs for the target/communication scripts outside of these functions?
siemen11
force-pushed
the
otsca_test
branch
7 times, most recently
from
c36a40b to
e8b1d8b
Compare
siemen11
force-pushed
the
otsca_test
branch
2 times, most recently
from
660cb46 to
31cf280
Compare
siemen11
force-pushed
the
otsca_test
branch
5 times, most recently
from
8aae6a2 to
eb0c143
Compare
siemen11
force-pushed
the
otsca_test
branch
7 times, most recently
from
ecbad43 to
9a9bbc4
Compare
siemen11
force-pushed
the
otsca_test
branch
10 times, most recently
from
0f1d2c7 to
2618750
Compare
siemen11
force-pushed
the
otsca_test
branch
4 times, most recently
from
23c4ffe to
901171d
Compare
nasahlpa
reviewed
Sep 1, 2025
| # Initialize ChipWhisperer scope. This is needed to program the binary. | ||
| # Note that the actual scope config for capturing traces is later | ||
| # initialized. | ||
| self.scope = cw.scope(sn=self.husky_serial) |
Collaborator
There was a problem hiding this comment.
We need to keep passing the husky_serial as somehow the CW driver needs that. Now, when having attached multiple CW Huskies, the CW driver asserts that multiple are attached and it needs the serial number.
Collaborator
There was a problem hiding this comment.
Will add it by updating your commit.
Bitstreams were generated with: ./bazelisk.sh build //hw/bitstream/vivado:fpga_cw310_test_rom ot-sca_cw310 binaries & bitstreams & opentitantool: commit: lowRISC/opentitan@867c06a ot-sca_cw310_aes binaries & bitstreams: commit: lowRISC/opentitan@51a8f50 ot-sca_cw310_otbn binaries & bitstreams: commit: lowRISC/opentitan@2898576 ot-sca_cw310_kmac binaries & bitstreams: commit: lowRISC/opentitan@a288f62 Signed-off-by: Pascal Nasahl <nasahlpa@lowrisc.org>
Update the yaml files to version v1.0.3 of OpenTitan's pentest framework. Signed-off-by: Siemen Dhooghe <sdhooghe@google.com>
Integrate the capture and fault injection scripts to the latest pentest framework v1.0.3. This also deprecates the CW305 board and removes the output_len and input_len values in the cfg. Signed-off-by: Siemen Dhooghe <sdhooghe@google.com> Co-authored-by: Pascal Nasahl <nasahlpa@lowrisc.org>
nasahlpa
approved these changes
Sep 18, 2025
Collaborator
nasahlpa
left a comment
nasahlpa
left a comment
There was a problem hiding this comment.
Thanks Siemen!
In summary, this PR:
- Updates the CW310 binaries and bitstreams
- Does autoformatting of the Python code
- Update the communication scripts such that they work with the latest pentest framework
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update ot-sca to latest pentestOS on OT.
To do: