Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/active_record/userstamp/stampable.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ module ActiveRecord::Userstamp::Stampable
before_validation :set_updater_attribute, if: :record_userstamp
before_validation :set_creator_attribute, on: :create, if: :record_userstamp
before_save :set_updater_attribute, if: :record_userstamp
before_save :set_creator_attribute, on: :create, if: :record_userstamp
before_create :set_creator_attribute, if: :record_userstamp
before_destroy :set_deleter_attribute, if: :record_userstamp
end

Expand Down
15 changes: 15 additions & 0 deletions spec/lib/stamping_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,21 @@
expect(person.creator).to eq(@hera)
expect(person.updater).to eq(@zeus)
end

it 'does not reset the creator when not defined previously' do
expect(User.stamper).to eq(@zeus)
person = nil
Person.without_stamps do
person = Person.create(name: 'David', updater_id: @hera.id)
expect(person.creator_id).to be_nil
expect(person.updater_id).to eq(@hera.id)
end

person.name = 'Julian'
person.save!
expect(person.creator_id).to be_nil
end

end

context 'when saving without validations' do
Expand Down