refactor: clean up code

Author: lppedd

.idea/inspectionProfiles/Project.xml

@@ -158,7 +158,7 @@ public void revalidate() {
     defaultTokensFilePickerPanel.revalidateComponent();
   }
 
-  @SuppressWarnings("ConstantExpression")
+  @SuppressWarnings({"ConstantExpression", "InstanceVariableUsedBeforeInitialized"})
   private void finishUpComponents(
       @NotNull final Project project,
       @NotNull final Disposable disposable) {
@@ -230,6 +230,7 @@ private void finishUpComponents(
     defaultsPanel.add(JBUI.Borders.emptyTop(7).wrap(defaultTokensPanel), gc);
   }
 
+  @SuppressWarnings("ConstantExpression")
   @Nullable
   private HyperlinkLabel buildTranslatorLabel() {
     final var name = CCBundle.getWithDefault("cc.translation.translator.name", "");
@@ -249,8 +250,6 @@ private HyperlinkLabel buildTranslatorLabel() {
     } else {
       if (new UrlValidator(new String[] {"http", "https"}, NO_FRAGMENTS).isValid(url)) {
         final var hyperlink = "<hyperlink>" + name + "</hyperlink>";
-
-        // noinspection UnstableApiUsage
         label.setTextWithHyperlink(CCBundle.get("cc.translation.text") + " " + hyperlink);
         label.setHyperlinkTarget(url);
       } else {

src/main/java/com/github/lppedd/cc/configuration/CCMainConfigurableGui.java

@@ -3,7 +3,6 @@ package com.github.lppedd.cc.whatsnew
 import com.github.lppedd.cc.CC
 import com.github.lppedd.cc.api.WhatsNewPage
 import com.github.lppedd.cc.api.WhatsNewProvider
-import com.intellij.ide.plugins.IdeaPluginDescriptor
 import com.intellij.ide.plugins.PluginManagerCore
 import com.intellij.ide.util.PropertiesComponent
 import com.intellij.openapi.extensions.PluginDescriptor
@@ -45,7 +44,7 @@ internal class InternalWhatsNewProvider : WhatsNewProvider {
 
   override fun shouldDisplayAtStartup(): Boolean {
     val properties = PropertiesComponent.getInstance()
-    val installedVersion = getPlugin()?.version ?: return false
+    val installedVersion = getPluginVersion() ?: return false
     val registeredVersion = properties.getValue(PROPERTY_VERSION, "0.0.0")
 
     if (PluginVersion(installedVersion) > PluginVersion(registeredVersion)) {
@@ -63,8 +62,10 @@ internal class InternalWhatsNewProvider : WhatsNewProvider {
   override fun getPages(): List<WhatsNewPage> =
     whatsNewPages
 
-  private fun getPlugin(): IdeaPluginDescriptor? =
-    PluginManagerCore.getPlugin(PluginId.getId(CC.PluginId))
+  private fun getPluginVersion(): String? {
+    val plugin = PluginManagerCore.getPlugin(PluginId.getId(CC.PluginId))
+    return plugin?.version
+  }
 
   private class PluginVersion(version: String) : Comparable<PluginVersion> {
     private val parts = version.split(".").map(String::toInt)