refactor: remove unnecessary Application extension functions

Author: lppedd

src/main/kotlin/com/github/lppedd/cc/CCExtensions.kt

@@ -5,7 +5,6 @@ import com.intellij.codeInsight.completion.CompletionParameters
 import com.intellij.codeInsight.template.impl.TemplateManagerImpl
 import com.intellij.codeInsight.template.impl.TemplateState
 import com.intellij.openapi.actionSystem.Presentation
-import com.intellij.openapi.application.Application
 import com.intellij.openapi.application.ApplicationManager
 import com.intellij.openapi.application.ex.ApplicationUtil
 import com.intellij.openapi.diagnostic.Logger
@@ -41,15 +40,6 @@ import kotlin.internal.InlineOnly
 import kotlin.math.max
 import kotlin.math.min
 
-// region Application
-
-internal inline val application: Application
-  get() = ApplicationManager.getApplication()
-
-internal inline fun <reified T> Application.service(): T =
-  getService(T::class.java)
-
-// endregion
 // region PsiElement
 
 @InlineOnly

src/main/kotlin/com/github/lppedd/cc/inspection/CommitInspectionsRegistrarStartupActivity.kt

@@ -2,9 +2,8 @@ package com.github.lppedd.cc.inspection
 
 import com.github.lppedd.cc.api.CommitInspectionProvider
 import com.github.lppedd.cc.api.CommitInspectionProviderService
-import com.github.lppedd.cc.application
-import com.github.lppedd.cc.service
 import com.intellij.codeInspection.ex.LocalInspectionToolWrapper
+import com.intellij.openapi.components.service
 import com.intellij.openapi.project.DumbAware
 import com.intellij.openapi.project.Project
 import com.intellij.openapi.startup.ProjectActivity
@@ -20,7 +19,7 @@ internal class CommitInspectionsRegistrarStartupActivity : ProjectActivity, Dumb
   }
 
   override suspend fun execute(project: Project) {
-    val inspectionProviderService = application.service<CommitInspectionProviderService>()
+    val inspectionProviderService = service<CommitInspectionProviderService>()
     val inspectionProviders = inspectionProviderService.getInspectionProviders()
     val inspections = inspectionProviders.flatMap(CommitInspectionProvider::getInspections)
 

src/main/kotlin/com/github/lppedd/cc/whatsnew/WhatsNewDialog.kt

@@ -1,10 +1,13 @@
 package com.github.lppedd.cc.whatsnew
 
-import com.github.lppedd.cc.*
+import com.github.lppedd.cc.CCBundle
 import com.github.lppedd.cc.api.WhatsNewProvider
 import com.github.lppedd.cc.api.WhatsNewProviderService
+import com.github.lppedd.cc.setFocused
+import com.github.lppedd.cc.setName
 import com.github.lppedd.cc.ui.CCDialogWrapper
 import com.github.lppedd.cc.ui.NoContentTabbedPaneWrapper
+import com.intellij.openapi.components.service
 import com.intellij.openapi.project.Project
 import com.intellij.openapi.ui.DialogWrapper.DialogStyle.COMPACT
 import com.intellij.ui.SimpleColoredText
@@ -28,7 +31,7 @@ internal class WhatsNewDialog(project: Project) : CCDialogWrapper(project) {
   private val newerAction = NewerAction()
   private val tabSelectedHandlers = mutableMapOf<Int, () -> Unit>()
 
-  private val providers = application.service<WhatsNewProviderService>()
+  private val providers = service<WhatsNewProviderService>()
     .getWhatsNewProviders()
     .asSequence()
     .sortedWith(WhatsNewProviderComparator)

src/main/kotlin/com/github/lppedd/cc/whatsnew/WhatsNewStartupActivity.kt

@@ -2,8 +2,7 @@ package com.github.lppedd.cc.whatsnew
 
 import com.github.lppedd.cc.api.WhatsNewProvider
 import com.github.lppedd.cc.api.WhatsNewProviderService
-import com.github.lppedd.cc.application
-import com.github.lppedd.cc.service
+import com.intellij.openapi.components.service
 import com.intellij.openapi.project.DumbAware
 import com.intellij.openapi.project.Project
 import com.intellij.openapi.startup.ProjectActivity
@@ -21,7 +20,7 @@ internal class WhatsNewStartupActivity : ProjectActivity, DumbAware {
       return
     }
 
-    val shouldDisplay = application.service<WhatsNewProviderService>()
+    val shouldDisplay = service<WhatsNewProviderService>()
       .getWhatsNewProviders()
       .asSequence()
       .filter(WhatsNewProvider::shouldDisplayAtStartup)