Skip to content

Commit d659f72

Browse files
irui-wangSasha Levin
authored andcommitted
media: mediatek: encoder: Fix uninitialized scalar variable issue
[ Upstream commit 88e935d ] UNINIT checker finds some instances of variables that are used without being initialized, for example using the uninitialized value enc_result.is_key_frm can result in unpredictable behavior, so initialize these variables after declaring. Fixes: 4e855a6 ("[media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver") Cc: stable@vger.kernel.org Signed-off-by: Irui Wang <irui.wang@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent e2a4539 commit d659f72

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

drivers/media/platform/mediatek/vcodec/encoder/mtk_vcodec_enc.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -864,7 +864,7 @@ static void vb2ops_venc_buf_queue(struct vb2_buffer *vb)
864864
static int vb2ops_venc_start_streaming(struct vb2_queue *q, unsigned int count)
865865
{
866866
struct mtk_vcodec_enc_ctx *ctx = vb2_get_drv_priv(q);
867-
struct venc_enc_param param;
867+
struct venc_enc_param param = { };
868868
int ret;
869869
int i;
870870

@@ -1018,7 +1018,7 @@ static int mtk_venc_encode_header(void *priv)
10181018
int ret;
10191019
struct vb2_v4l2_buffer *src_buf, *dst_buf;
10201020
struct mtk_vcodec_mem bs_buf;
1021-
struct venc_done_result enc_result;
1021+
struct venc_done_result enc_result = { };
10221022

10231023
dst_buf = v4l2_m2m_dst_buf_remove(ctx->m2m_ctx);
10241024
if (!dst_buf) {
@@ -1139,7 +1139,7 @@ static void mtk_venc_worker(struct work_struct *work)
11391139
struct vb2_v4l2_buffer *src_buf, *dst_buf;
11401140
struct venc_frm_buf frm_buf;
11411141
struct mtk_vcodec_mem bs_buf;
1142-
struct venc_done_result enc_result;
1142+
struct venc_done_result enc_result = { };
11431143
int ret, i;
11441144

11451145
/* check dst_buf, dst_buf may be removed in device_run

0 commit comments

Comments
 (0)