fix: _clean_content newline condensation bug#107
Open
Jah-yee wants to merge 1 commit intolsdefine:mainfrom
Open
fix: _clean_content newline condensation bug#107Jah-yee wants to merge 1 commit intolsdefine:mainfrom
Jah-yee wants to merge 1 commit intolsdefine:mainfrom
Conversation
Changed '\\\\n' to '\\n' in the condition check.
The bug: '\\\\n' (3-char \\n) never matched the pattern
r'(\\r?\\n){3,}' which only contains the 2-char sequence
backslash+n. This caused all patterns to be replaced with ''
(empty string) instead of correctly condensing newlines.
Fix: use '\\n' (2-char backslash+n) so the condition
correctly identifies the newline-collapse pattern.
Closes lsdefine#87
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
In `_clean_content`, the condition `'\\n' in p\' was checking for a 3-character sequence (backslash, backslash, n) in the patterns. However, the third pattern `r'(\r?\n){3,}'` only contains the 2-character sequence (backslash, n).
Result: All patterns were being replaced with `''` (empty string), destroying paragraph spacing.
Fix: Change `'\\n'\' to `'\n'\' so the condition correctly identifies the newline-collapse pattern and replaces it with `'\n\n'` instead.
Testing
The fix was verified by checking that the condition now correctly evaluates:
Related
Closes #87
Signed-off-by: Jah-yee