DM-55282: Add additional info about max number of cosmic ray spans in TooManyCosmicRays exception.#1325
Open
erykoff wants to merge 1 commit into
Open
DM-55282: Add additional info about max number of cosmic ray spans in TooManyCosmicRays exception.#1325erykoff wants to merge 1 commit into
erykoff wants to merge 1 commit into
Conversation
laurenam
approved these changes
Jun 22, 2026
| Maximum number of cosmic ray spans allowed. | ||
| """ | ||
| def __init__(self, maxCosmicRays, **kwargs): | ||
| def __init__(self, maxCosmicRays, maxCosmicRaySpans=-1, **kwargs): |
Contributor
There was a problem hiding this comment.
Heh, so it's not an API change?
| """ | ||
| def __init__(self, maxCosmicRays, **kwargs): | ||
| def __init__(self, maxCosmicRays, maxCosmicRaySpans=-1, **kwargs): | ||
| msg = f"Cosmic ray task found more than {maxCosmicRays} cosmics." |
Contributor
There was a problem hiding this comment.
The message should be updated (to either identify which condition wasn't met or at least indicate it was one of two...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.