Update tests for dates in prenight index always being date instances

Author: ehneilsen

tests/sim_archive/test_prenightindex.py

@@ -212,35 +212,35 @@ def test_get_prenight_index_from_bucket(self) -> None:
             # Create a mock prenight index JSON file similar to the sample data
             mock_index_data = {
                 "6c242afb-edd1-4cea-9f8c-80e0a18b4b75": {
-                    "sim_creation_day_obs": "2026-04-11",
+                    "sim_creation_day_obs": date(2026, 4, 11),
                     "daily_id": 2,
                     "visitseq_label": "Nominal start and overhead, ideal conditions",
                     "telescope": "simonyi",
-                    "first_day_obs": "2026-04-11",
-                    "last_day_obs": "2026-04-13",
+                    "first_day_obs": date(2026, 4, 11),
+                    "last_day_obs": date(2026, 4, 13),
                     "creation_time": "2026-04-11T14:13:55.024Z",
                     "scheduler_version": "3.21.1",
                     "sim_runner_kwargs": None,
                     "conda_env_sha256": "48bcf84e41a741ee67fe644b1ed8d5858d81a7ecfe012473fe2e2f0f3fc05095",
                     "parent_visitseq_uuid": "94fd43ff-5034-43cd-ac48-6461cdca7979",
-                    "parent_last_day_obs": "2026-04-10",
+                    "parent_last_day_obs": date(2026, 4, 10),
                     "tags": ["ideal", "nominal", "prenight"],
                     "comments": {},
                     "files": {},
                 },
                 "b9405aaf-dfe8-4508-ad90-cb37527dbc27": {
-                    "sim_creation_day_obs": "2026-04-11",
+                    "sim_creation_day_obs": date(2026, 4, 11),
                     "daily_id": 3,
                     "visitseq_label": "Nominal start and overhead, ideal conditions 2",
                     "telescope": "simonyi",
-                    "first_day_obs": "2026-04-11",
-                    "last_day_obs": "2026-04-13",
+                    "first_day_obs": date(2026, 4, 11),
+                    "last_day_obs": date(2026, 4, 13),
                     "creation_time": "2026-04-11T14:21:27.332Z",
                     "scheduler_version": "3.21.1",
                     "sim_runner_kwargs": None,
                     "conda_env_sha256": "48bcf84e41a741ee67fe644b1ed8d5858d81a7ecfe012473fe2e2f0f3fc05095",
                     "parent_visitseq_uuid": "94fd43ff-5034-43cd-ac48-6461cdca7979",
-                    "parent_last_day_obs": "2026-04-10",
+                    "parent_last_day_obs": date(2026, 4, 10),
                     "tags": ["ideal", "nominal", "prenight", "rewards"],
                     "comments": {},
                     "files": {},
@@ -291,15 +291,15 @@ def test_get_prenight_index_from_bucket(self) -> None:
 
             # Check that the first row has expected data
             first_row = result.loc["6c242afb-edd1-4cea-9f8c-80e0a18b4b75"]
-            self.assertEqual(first_row["sim_creation_day_obs"], "2026-04-11")
+            self.assertEqual(first_row["sim_creation_day_obs"], date(2026, 4, 11))
             self.assertEqual(first_row["daily_id"], 2)
             self.assertIn("ideal", first_row["tags"])
             self.assertIn("nominal", first_row["tags"])
             self.assertIn("prenight", first_row["tags"])
 
             # Check that the second row has expected data
             second_row = result.loc["b9405aaf-dfe8-4508-ad90-cb37527dbc27"]
-            self.assertEqual(second_row["sim_creation_day_obs"], "2026-04-11")
+            self.assertEqual(second_row["sim_creation_day_obs"], date(2026, 4, 11))
             self.assertEqual(second_row["daily_id"], 3)
             self.assertIn("ideal", second_row["tags"])
             self.assertIn("nominal", second_row["tags"])
@@ -311,18 +311,18 @@ def test_get_prenight_index(self) -> None:
         sample_uuid = "6c242afb-edd1-4cea-9f8c-80e0a18b4b75"
         mock_result = pd.DataFrame(
             {
-                "sim_creation_day_obs": ["2026-04-11"],
+                "sim_creation_day_obs": [date(2026, 4, 11)],
                 "daily_id": [1],
                 "visitseq_label": ["Test simulation"],
                 "telescope": ["simonyi"],
-                "first_day_obs": ["2026-04-11"],
-                "last_day_obs": ["2026-04-13"],
+                "first_day_obs": [date(2026, 4, 11)],
+                "last_day_obs": [date(2026, 4, 13)],
                 "creation_time": ["2026-04-11T14:13:55.024Z"],
                 "scheduler_version": ["3.21.1"],
                 "sim_runner_kwargs": [None],
                 "conda_env_sha256": ["48bcf84e41a741ee67fe644b1ed8d5858d81a7ecfe012473fe2e2f0f3fc05095"],
                 "parent_visitseq_uuid": ["94fd43ff-5034-43cd-ac48-6461cdca7979"],
-                "parent_last_day_obs": ["2026-04-10"],
+                "parent_last_day_obs": [date(2026, 4, 10)],
                 "tags": [["ideal", "nominal", "prenight"]],
                 "comments": [{}],
                 "files": [{}],