Skip to content

DM-53837: Replace column definitions in DRP schemas with references to a base schema#446

Merged
JeremyMcCormick merged 7 commits into
mainfrom
tickets/DM-53837
May 20, 2026
Merged

DM-53837: Replace column definitions in DRP schemas with references to a base schema#446
JeremyMcCormick merged 7 commits into
mainfrom
tickets/DM-53837

Conversation

@JeremyMcCormick
Copy link
Copy Markdown
Collaborator

@JeremyMcCormick JeremyMcCormick commented Jan 15, 2026

This PR converts lsstcam.yaml, imsim.yaml, and hsc.yaml to use shared column references from a new schema drp_base.yaml, which functions as a column dictionary. The new schema was created from the current contents of lsstcam.yaml, plus some detection flags present in imsim.yaml and hsc.yaml.

The columns in drp_base.yaml were sorted alphabetically using felis dump --sort-columns. The drp_base.yaml contains only the table and column definitions without any constraints, primary keys, etc.

Checklist

When making changes to YAML files in the schemas directory:

@JeremyMcCormick JeremyMcCormick force-pushed the tickets/DM-53837 branch 2 times, most recently from 82d1761 to 65dee39 Compare May 18, 2026 16:49
@JeremyMcCormick JeremyMcCormick marked this pull request as ready for review May 18, 2026 17:05
@JeremyMcCormick
Copy link
Copy Markdown
Collaborator Author

JeremyMcCormick commented May 18, 2026

@gpdf As discussed, I've also added the detection flags, e.g., detect_isPrimary, etc., to the base schema. This also included the flag fields merge_peak_sky and sky_object.

I also changed a few instances of fits:tunit to ivoa:unit in hsc.yaml and imsim.yaml.

Copy link
Copy Markdown
Collaborator

@gpdf gpdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix "LSSTComCam" in the Visit table description for lsstcam.yaml

Comment thread python/lsst/sdm/schemas/lsstcam.yaml Outdated
Copy link
Copy Markdown
Collaborator

@gpdf gpdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; go for it

@JeremyMcCormick JeremyMcCormick merged commit c3e38a4 into main May 20, 2026
18 checks passed
@JeremyMcCormick JeremyMcCormick deleted the tickets/DM-53837 branch May 20, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants