DM-53837: Replace column definitions in DRP schemas with references to a base schema#446
Merged
Conversation
f87f0ea to
c28136d
Compare
245e3fc to
8d0271a
Compare
This was referenced May 11, 2026
2ce60f6 to
3a8216f
Compare
4 tasks
5c476d0 to
3f54e1c
Compare
82d1761 to
65dee39
Compare
Collaborator
Author
|
@gpdf As discussed, I've also added the detection flags, e.g., I also changed a few instances of |
65dee39 to
bd3afcf
Compare
gpdf
requested changes
May 18, 2026
Collaborator
gpdf
left a comment
There was a problem hiding this comment.
Please fix "LSSTComCam" in the Visit table description for lsstcam.yaml
c86bd0a to
4a2b6cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR converts
lsstcam.yaml,imsim.yaml, andhsc.yamlto use shared column references from a new schemadrp_base.yaml, which functions as a column dictionary. The new schema was created from the current contents oflsstcam.yaml, plus some detection flags present inimsim.yamlandhsc.yaml.The columns in
drp_base.yamlwere sorted alphabetically usingfelis dump --sort-columns. Thedrp_base.yamlcontains only the table and column definitions without any constraints, primary keys, etc.Checklist
When making changes to YAML files in the schemas directory: