Skip to content

Commit 4b76d0b

Browse files
authored
Merge pull request #95 from lsst/tickets/SP-1902_patch
SP-1902 patch
2 parents 1aa9153 + 49cf6cb commit 4b76d0b

1 file changed

Lines changed: 7 additions & 8 deletions

File tree

DP1/300_Science_Demos/304_Cosmology/304_3_Abell360_weak_lensing.ipynb

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"Data Release: <a href=\"https://dp1.lsst.io/\">Data Preview 1</a> <br>\n",
2222
"Container Size: large <br>\n",
2323
"LSST Science Pipelines version: Release r29.2.0 <br>\n",
24-
"Last verified to run: 2025-09-05 <br>\n",
24+
"Last verified to run: 2025-11-13 <br>\n",
2525
"Repository: <a href=\"https://github.com/lsst/tutorial-notebooks\">github.com/lsst/tutorial-notebooks</a> <br>"
2626
]
2727
},
@@ -37,7 +37,7 @@
3737
"**Packages:** `lsst.daf.butler`, `lsst.rsp`, `lsst.afw.display`, `lsst.geom`.\n",
3838
"\n",
3939
"**Credit:**\n",
40-
"Developed by Shenming Fu and the Rubin Community Science team., inspired by Céline Combet's and Prakruth Adari's Notebooks for [ComCam Clusters](https://github.com/lsst-sitcom/comcam_clusters). See also Tech Notes [C. Combet et al.,](https://sitcomtn-161.lsst.io/) and [P. Adari et al.](https://sitcomtn-163.lsst.io/) \n",
40+
"Developed by Shenming Fu and the Rubin Community Science team. Inspired by Céline Combet's and Prakruth Adari's Notebooks for [ComCam Clusters](https://github.com/lsst-sitcom/comcam_clusters). See also Tech Notes [C. Combet et al.,](https://sitcomtn-161.lsst.io/) and [P. Adari et al.](https://sitcomtn-163.lsst.io/) \n",
4141
"Part of this notebook will be used for a journal article about a Rubin view of A360 (led by Anja von der Linden).\n",
4242
"Please consider acknowledging them if this notebook is used for the preparation of journal articles, software releases, or other notebooks.\n",
4343
"\n",
@@ -224,7 +224,7 @@
224224
"\n",
225225
"Use the TAP service to make a cone search of the Object catalog for objects detected in the `deep_coadd` images within 0.4 degrees of the BCG.\n",
226226
"\n",
227-
"Define the query to return shape parameters in the selected band, photometry in the *riz* bands, and other useful columns."
227+
"Define the query to return shape parameters in the selected band, photometry in the *riz* bands, and other useful columns. Compute the signal-to-noise ratio (SNR) in the query since it is not included in the schema (otherwise, to save time, it is not recommended to do computation in the query)."
228228
]
229229
},
230230
{
@@ -341,7 +341,7 @@
341341
"metadata": {},
342342
"outputs": [],
343343
"source": [
344-
"afw_display.mtv(deep_coadd)\n",
344+
"afw_display.image(deep_coadd)\n",
345345
"afw_display.setMaskTransparency(100)"
346346
]
347347
},
@@ -392,7 +392,7 @@
392392
"This is the extendedness in the reference band. The extendness is either 0 or 1, and it is based on the difference between the PSF magnitude and the Composite-Model (CModel) magnitude ([Abazajian et al. 2004](https://ui.adsabs.harvard.edu/abs/2004AJ....128..502A/abstract), [Bosch et al. 2018](https://ui.adsabs.harvard.edu/abs/2018PASJ...70S...5B/abstract)). \n",
393393
"\n",
394394
"Use the *riz* CModel photometry [(Bosch et al. 2018)](https://ui.adsabs.harvard.edu/abs/2018PASJ...70S...5B/abstract),\n",
395-
"which is appropriate for measurements of galaxies (extended objects), and retain only objects with signal-to-noise ratio SNR>5 to select well-detected objects. Select the objects that do not have flag parameters `*_cModel_flag` set to 1, to ensure the quality."
395+
"which is appropriate for measurements of galaxies (extended objects), and retain only objects with SNR>5 to select well-detected objects. Select the objects that do not have flag parameters `*_cModel_flag` set to 1, to ensure the quality."
396396
]
397397
},
398398
{
@@ -410,7 +410,6 @@
410410
" sel &= obj_cat[f\"{band}_cModel_SNR\"] > 5.\n",
411411
"obj_cat = obj_cat[sel]\n",
412412
"\n",
413-
"assert len(obj_cat) == 21975\n",
414413
"print('Number of objects is', len(obj_cat))"
415414
]
416415
},
@@ -497,8 +496,8 @@
497496
" ax[i].axhline(color - rs_half_width, ls=\"--\", color=\"grey\", alpha=1)\n",
498497
" ax[i].axhline(color + rs_half_width, ls=\"--\", color=\"grey\", alpha=1)\n",
499498
"\n",
500-
" sel_bg &= np.abs(obj_cat[f\"{band1}_cModelMag\"]\n",
501-
" - obj_cat[f\"{band2}_cModelMag\"]) > (color + rs_half_width)\n",
499+
" sel_bg &= (obj_cat[f\"{band1}_cModelMag\"]\n",
500+
" - obj_cat[f\"{band2}_cModelMag\"]) > (color + rs_half_width)\n",
502501
" sel_rs &= np.abs((obj_cat[f\"{band1}_cModelMag\"]\n",
503502
" - obj_cat[f\"{band2}_cModelMag\"]) - color) < rs_half_width\n",
504503
"\n",

0 commit comments

Comments
 (0)