SP-3129: PP review and release NB 101 & 201 for alert archive and packets#144
SP-3129: PP review and release NB 101 & 201 for alert archive and packets#144jeffcarlin wants to merge 1 commit into
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| "\n", | ||
| "**LSST data products:** Alert packets.\n", | ||
| "\n", | ||
| "**Packages:** `lsst.rsp.RSPClient`, `lsst.rsp..get_service_url`, `fastavro`.\n", |
There was a problem hiding this comment.
Looks like a typo here (two dots before method)
| "The FITS response is a multi-extension file with the following extensions.\n", | ||
| "\n", | ||
| "* `PRIMARY`: A header with telescope and instrument.\n", | ||
| "* `ALERT`: Data from the associated DIA (static-sky) or SS (moving) object.\n", |
There was a problem hiding this comment.
The Alert HDU will contain the top-level scalar alert fields (diaSourceId, observation_reason, target_name, etc.) merged together with whichever of diaObject/ssObject/mpc_orbits is present. Perhaps worth adding that to the description?
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "alert_id = \"170059317401616524\"" |
There was a problem hiding this comment.
Perhaps also worth mentioning that Herald supports the IAU format ID as well (LSST-AP-DS-{ID})
| "outputs": [], | ||
| "source": [ | ||
| "response = await client.get(url, params={\"ID\": alert_id})\n", | ||
| "response?" |
There was a problem hiding this comment.
Should there be a raise_for_status() after this as well?
| "metadata": {}, | ||
| "source": [ | ||
| "**DIFFIM, SCIENCE, TEMPLATE**\\\n", | ||
| "Option to display the image stamp \"triplet\" of science, template, and difference image for the `dia_hdul`." |
There was a problem hiding this comment.
hdul instead of dia_hdul?
| " # display.scale(\"linear\", \"zscale\")\n", | ||
| " display.scale(\"linear\", \"minmax\")\n", | ||
| " display.image(image)\n", | ||
| " plt.plot(pixels[0], pixels[0], 'o', ms=20, mew=1, color='None', mec='yellow')\n", |
There was a problem hiding this comment.
Should the y here be pixels[1]?
2 participants
Add the alert access notebooks to the tutorials repo.