SP 2407: NB 103_8 matplotlib#91
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
MelissaGraham
left a comment
There was a problem hiding this comment.
Left a list of requested changes in the Jira ticket.
|
@MelissaGraham Thanks. I've adjusted the notebook and addressed your comments. |
8794d67 to
63c4f6c
Compare
|
I noticed in a previous commit I edited 103_5 by accident. I tried "Interactive Rebase" but it didn't work. So I used "Git Revert" and it worked. |
MelissaGraham
left a comment
There was a problem hiding this comment.
A demo of how to see the docs for display.scale or display.image is tucked into the end of the subsection on masks, but it would be more relevant at the start of section 2 or 2.1.
Subsections headers in sections 2 and 3 are missing a period after the number (like as in the subsections of section 1).
Section 3 header can just be "Display an image with imshow", the matplotlib isn't necessary and then this would better match the section 2 header.
Looks like you'll have to update with rebase but then please go ahead and merge, thanks Shenming.
c3318a5 to
27bd789
Compare
|
@MelissaGraham Thank you very much. I've addressed your comments and updated the notebook, and I also did the rebase. After the checks I will press the merge button. |
No description provided.