DM-55482: Improve coverage of disable_implicit_threading#245
Open
timj wants to merge 2 commits into
Open
Conversation
Add NUMBA_NUM_THREADS, ARROW_IO_THREADS, VECLIB_MAXIMUM_THREADS, RAYON_NUM_THREADS, POLARS_MAX_THREADS, and BLIS_NUM_THREADS to the environment variables set by set_thread_envvars. Resize existing pyarrow thread pools explicitly since they are sized from the environment only when each pool is first used and do not react to environment variables after creation. Log a warning when threadpoolctl is not installed since thread pools of already-loaded libraries can then no longer be limited. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
==========================================
- Coverage 94.73% 94.48% -0.25%
==========================================
Files 51 51
Lines 4007 4047 +40
==========================================
+ Hits 3796 3824 +28
- Misses 211 223 +12 ☔ View full report in Codecov by Harness. |
numba reads NUMBA_NUM_THREADS only at import time, so setting the environment variable in disable_implicit_threading has no effect on a numba that is already imported. Call numba.set_num_threads(1) as well. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add NUMBA_NUM_THREADS, ARROW_IO_THREADS, VECLIB_MAXIMUM_THREADS, RAYON_NUM_THREADS, POLARS_MAX_THREADS, and BLIS_NUM_THREADS to the environment variables set by set_thread_envvars.
Resize existing pyarrow thread pools explicitly since they are sized from the environment only when each pool is first used and do not react to environment variables after creation.
Log a warning when threadpoolctl is not installed since thread pools of already-loaded libraries can then no longer be limited.
Checklist
doc/changes