Add Confirm Password field and improve layout of password forms#110
Conversation
lstein
left a comment
There was a problem hiding this comment.
Please format the "Current Password", "New Password" and "Confirm New Password" text input boxes so that their left edges line up in a nice column.
Modify the "Generate Strong Password" button to align underneath the three password fields and put a little lightning bolt icon next to it to indicate that this is a clickable user interface element.
Done in commit 460a22d. All three password fields now use a |
lstein
left a comment
There was a problem hiding this comment.
The last commit very much improved the look of the User Profile page. Please make similar changes to the Edit User page used by the administrator to modify the user profile:
- Align the left margins of the Display Name and New Password text fields.
- Align Generate Strong Password with the left side of the New Password text field.
- Add a lightning bolt to the left of Generate Strong Password
In this case, you do not need to add a new password confirmation box. The Administrator only has to enter the new password once.
Done in commit 92d8e83. The Edit User modal now uses |
Co-authored-by: lstein <111189+lstein@users.noreply.github.com>
92d8e83 to
484f2f3
Compare
…8937) * Add user management UI for admin and regular users (#106) * Add user management UI and backend API endpoints Co-authored-by: lstein <111189+lstein@users.noreply.github.com> Fix user management feedback: cancel/back navigation, system user filter, tooltip fix Co-authored-by: lstein <111189+lstein@users.noreply.github.com> Make Back button on User Management page more prominent Co-authored-by: lstein <111189+lstein@users.noreply.github.com> * chore(frontend): typegen --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lstein <111189+lstein@users.noreply.github.com> Co-authored-by: Lincoln Stein <lincoln.stein@gmail.com> * Add Confirm Password field to My Profile password change form (#110) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lstein <111189+lstein@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: lstein <111189+lstein@users.noreply.github.com> Co-authored-by: Alexander Eichhorn <alex@eichhorn.dev>


Summary
This PR improves the password-related forms in the multiuser UI with two sets of changes:
My Profile (
UserProfile.tsx)The password change form lacked a confirmation field, leaving users vulnerable to undetected typos. A Confirm New Password field has been added with mismatch validation that blocks submission until both new-password fields agree. All three password fields and the Generate button are laid out in a two-column grid so their left edges align neatly.
confirmPasswordstate + show/hide togglepasswordsMatch: requiresnewPassword.length > 0 && newPassword === confirmPasswordisPasswordChangeValidnow gates onpasswordsMatchFormErrorMessageshown when fields are non-empty and mismatchedGrid templateColumns={PASSWORD_GRID_COLUMNS}('180px 1fr') so every input's left edge is aligned in a columnPiLightningFilllightning bolt iconPASSWORD_GRID_COLUMNSconstant extracted to avoid duplicationAdmin Edit/Create User modal (
UserManagement.tsx)The Display Name and Password fields in the admin user form have been given the same two-column grid treatment for visual consistency.
Grid templateColumns={FORM_GRID_COLUMNS}('120px 1fr') with right-aligned labels so all input left edges alignPiLightningFilllightning bolt iconFORM_GRID_COLUMNSconstant extracted to avoid duplicationen.jsonconfirmPassword,confirmPasswordPlaceholder,passwordsDoNotMatchkeysRelated Issues / Discussions
QA Instructions
My Profile:
/profile).Admin Edit User modal:
Merge Plan
Checklist
What's Newcopy (if doing a release after this PR)Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.