Fix non-POSIX paths in Libdir under Windows#477
Merged
Conversation
This fixes using the GStreamer plugins .pc files with e.g. CMake, which interprets backslashes as an escape code and strips them automatically.
nirbheek
approved these changes
Jul 23, 2025
Contributor
|
Yes, pkgconfig files should never have backslashes as path-separators. |
Owner
|
Sounds good, can we wait till the next cargo release or do you prefer to have a point release with this fix sooner? |
Contributor
|
It can wait, we've already patched it in cerbero. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @lu-zero ,
This fixes using the GStreamer plugins .pc files with e.g. CMake, which interprets backslashes as an escape code and strips them automatically.
This is an upstream fix for the following GStreamer MR: https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1895
cc @nirbheek