Skip to content

Commit 2e770ea

Browse files
committed
chore: move Data.Rat.NatSqrt.Real to Analysis (leanprover-community#39976)
It's about the real square root; that's firmly within analysis. Removing all transitive `Data` imports from `Analysis` will require moving certain basic files (such as `Data.String.Defs` to a new `Basic` directory).
1 parent dbc5514 commit 2e770ea

5 files changed

Lines changed: 3 additions & 6 deletions

File tree

Mathlib.lean

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2284,6 +2284,7 @@ public import Mathlib.Analysis.RCLike.Inner
22842284
public import Mathlib.Analysis.RCLike.Lemmas
22852285
public import Mathlib.Analysis.RCLike.Sqrt
22862286
public import Mathlib.Analysis.RCLike.TangentCone
2287+
public import Mathlib.Analysis.Rat.NatSqrt.Real
22872288
public import Mathlib.Analysis.Real.Cardinality
22882289
public import Mathlib.Analysis.Real.Hyperreal
22892290
public import Mathlib.Analysis.Real.OfDigits
@@ -4277,7 +4278,6 @@ public import Mathlib.Data.Rat.Floor
42774278
public import Mathlib.Data.Rat.Init
42784279
public import Mathlib.Data.Rat.Lemmas
42794280
public import Mathlib.Data.Rat.NatSqrt.Defs
4280-
public import Mathlib.Data.Rat.NatSqrt.Real
42814281
public import Mathlib.Data.Rat.Sqrt
42824282
public import Mathlib.Data.Rat.Star
42834283
public import Mathlib.Data.Real.Basic

Mathlib/Data/Rat/NatSqrt/Defs.lean

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public import Mathlib.Algebra.Order.Field.Basic
1111
/-!
1212
Rational approximation of the square root of a natural number.
1313
14-
See also `Mathlib.Data.Rat.NatSqrt.Real` for comparisons with the real square root.
14+
See also `Mathlib.Analysis.Rat.NatSqrt.Real` for comparisons with the real square root.
1515
-/
1616

1717
@[expose] public section

Mathlib/Tactic/Linter/DirectoryDependency.lean

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -618,9 +618,6 @@ def overrideAllowedImportDirs : NamePrefixRel := .ofArray #[
618618
(`Mathlib.Analysis.Convex.SimplicialComplex.AffineIndependentUnion, `Mathlib.AlgebraicTopology),
619619
(`Mathlib.Probability.Kernel.Category, `Mathlib.CategoryTheory), -- For the category of s-finite/Markov kernels
620620
(`Mathlib.RepresentationTheory.Continuous, `Mathlib.Topology), -- For continuous representations
621-
622-
-- TODO: reduce these with further moving files out of `Data`
623-
(`Mathlib.Data.Rat.NatSqrt.Real, `Mathlib.Analysis),
624621
-- TODO: think about the role of Analysis and Algebra, and perhaps further separation
625622
(`Mathlib.Algebra.Order.Archimedean.Real, `Mathlib.Analysis),
626623
(`Mathlib.Algebra.Star.CHSH, `Mathlib.Analysis),

MathlibTest/sqrt.lean

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import Mathlib.Tactic.Eval
22
import Mathlib.Tactic.NormNum.NatSqrt
3-
import Mathlib.Data.Rat.NatSqrt.Real
3+
import Mathlib.Analysis.Rat.NatSqrt.Real
44

55
open Nat
66

0 commit comments

Comments
 (0)