Upgrade to React Hot Loader#102
Open
drouillard wants to merge 2 commits intoluandro:masterfrom
Open
Conversation
Author
|
Seeing errors again on server - which is interesting since I made changes to client webpack
Server is having to restart to work. The client side hot reloading still seems to work? Will continue investigating |
Author
|
Actually I am seeing the HMR errors on the server even on a fresh pulldown of this project before my commits. It still works, just seems to restart the server. |
Author
|
For the linting errors I was seeing - similar issue Looks like eslint in command line could work. I use mine via Atom editor plugin which requires explicit inclusion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to address #99
I didn't remove the old hot loading module quite yet. Hot Loading did not work in general for me on OS X / Node V5 and V6 until I made this update. If this works for you feel free to merge. I can remove the old hot module reloading code with another PR. I tried originally but ran into some issues that I have since had trouble reproducing.
I also updated package.json to fix eslint config. The peer deps for Airbnb config were not being met.