Prepare a new v12 tag that sets Lua 5.5 as default version#5
Open
luau-project wants to merge 8 commits into
Open
Prepare a new v12 tag that sets Lua 5.5 as default version#5luau-project wants to merge 8 commits into
luau-project wants to merge 8 commits into
Conversation
* At the moment, the current action to setup MSVC ( https://github.com/ilammy/msvc-dev-cmd ) emits warnings due the use of EOL nodejs versions; * The action's maintainer does not respond PRs; * Apparently, there is no movement to fix such warnings; * Follow upstream (leafo's action) and use ( https://github.com/step-security/msvc-dev-cmd ).
cclauss
approved these changes
Jul 5, 2026
cclauss
reviewed
Jul 5, 2026
| fail-fast: false | ||
| matrix: | ||
| luaVersion: ["5.1.5", "5.2.4", "5.3.6", "5.4.8", "luajit", "luajit-2.0", "luajit-2.1", "luajit-2.0.5", "luajit-2.1.0-beta3", "luajit-openresty", "5.1", "5.4"] | ||
| luaVersion: ["5.1.5", "5.2.4", "5.3.6", "5.4.8", "5.5.0", "luajit", "luajit-2.0", "luajit-2.1", "luajit-2.0.5", "luajit-2.1.0-beta3", "luajit-openresty", "5.1", "5.4"] |
There was a problem hiding this comment.
Match line 16?
Suggested change
| luaVersion: ["5.1.5", "5.2.4", "5.3.6", "5.4.8", "5.5.0", "luajit", "luajit-2.0", "luajit-2.1", "luajit-2.0.5", "luajit-2.1.0-beta3", "luajit-openresty", "5.1", "5.4"] | |
| luaVersion: ["5.1.5", "5.2.4", "5.3.6", "5.4.8", "5.5.0", "luajit", "luajit-2.0", "luajit-2.1", "luajit-2.0.5", "luajit-2.1.0-beta3", "luajit-openresty", "5.1", "5.4", "5.5"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CC @hishamhm
Lua 5.5 and LuaRocks 3.13.0 were updated 7 months ago, then I think it is a reasonable time to bump versions here.
Thus, there were minor changes preparing to push a new tag on both luarocks-gh-actions-* repos accounting for Lua 5.5 and LuaRocks 3.13.0.
Changes
leafoaction https://github.com/leafo/gh-actions-lua, due warnings regarding the use of EOL nodejs versions by ilammy.Note
If there is no objection, I'll merge this PR and push a new tag tomorrow.
Question
I can see that both repos have issues disabled. Since the code on such repos have diverged enough from upstream, what do you think about enabling that feature so users can report them?