From d1a72ee412c6533f199c5e564ce792ba95378bf5 Mon Sep 17 00:00:00 2001
From: Benny Yao <bennyliaw@gmail.com>
Date: Thu, 12 Nov 2020 10:22:17 +0800
Subject: [PATCH] update LP percentage swap fee

introduce new constant LP_PCT_SWAP_FEE 0.35
keep existing BASE_EXCHANGE_FEE (0.4) in swap pages
use LP_PCT_SWAP_FEE (0.35) on pool page and position page
---
 src/components/PositionCard/index.tsx | 4 ++--
 src/pages/Pool/index.tsx              | 4 ++--
 src/utils/prices.ts                   | 3 ++-
 3 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/components/PositionCard/index.tsx b/src/components/PositionCard/index.tsx
index 65f3156d..b6a7eb66 100644
--- a/src/components/PositionCard/index.tsx
+++ b/src/components/PositionCard/index.tsx
@@ -12,7 +12,7 @@ import { useTokenBalance } from '../../state/wallet/hooks'
 import { ExternalLink, TYPE } from '../../theme'
 import { currencyId } from '../../utils/currencyId'
 import { unwrappedToken } from '../../utils/wrappedCurrency'
-import { BASE_EXCHANGE_FEE } from '../../utils/prices'
+import { LP_PCT_SWAP_FEE } from '../../utils/prices'
 import { ButtonPrimary, ButtonSecondary, ButtonEmpty } from '../Button'
 import { transparentize } from 'polished'
 import { CardNoise } from '../earn/styled'
@@ -149,7 +149,7 @@ export function MinimalPositionCard({ pair, showUnwrapped = false, border }: Pos
             <span role="img" aria-label="wizard-icon">
               ⭐️
             </span>{' '}
-            By adding liquidity you&apos;ll earn {BASE_EXCHANGE_FEE} of all trades on this pair proportional to your
+            By adding liquidity you&apos;ll earn {LP_PCT_SWAP_FEE} of all trades on this pair proportional to your
             share of the pool. Fees are added to the pool, accrue in real time and can be claimed by withdrawing your
             liquidity.
           </TYPE.subHeader>
diff --git a/src/pages/Pool/index.tsx b/src/pages/Pool/index.tsx
index f5b38e0a..de69fba0 100644
--- a/src/pages/Pool/index.tsx
+++ b/src/pages/Pool/index.tsx
@@ -4,7 +4,7 @@ import { Pair } from '@luaswap/sdk'
 import { Link } from 'react-router-dom'
 import { SwapPoolTabs } from '../../components/NavigationTabs'
 
-import { BASE_EXCHANGE_FEE } from '../../utils/prices'
+import { LP_PCT_SWAP_FEE } from '../../utils/prices'
 
 import FullPositionCard from '../../components/PositionCard'
 import { useUserHasLiquidityInAllTokens } from '../../data/V1'
@@ -124,7 +124,7 @@ export default function Pool() {
               </RowBetween>
               <RowBetween>
                 <TYPE.white fontSize={14}>
-                  {`Liquidity providers earn a ${BASE_EXCHANGE_FEE} fee on all trades proportional to their share of the pool. Fees are added to the pool, accrue in real time and can be claimed by withdrawing your liquidity.`}
+                  {`Liquidity providers earn a ${LP_PCT_SWAP_FEE} fee on all trades proportional to their share of the pool. Fees are added to the pool, accrue in real time and can be claimed by withdrawing your liquidity.`}
                 </TYPE.white>
               </RowBetween>
               {/* <ExternalLink
diff --git a/src/utils/prices.ts b/src/utils/prices.ts
index a3c3c96d..2fa83d84 100644
--- a/src/utils/prices.ts
+++ b/src/utils/prices.ts
@@ -4,7 +4,8 @@ import { ALLOWED_PRICE_IMPACT_HIGH, ALLOWED_PRICE_IMPACT_LOW, ALLOWED_PRICE_IMPA
 import { Field } from '../state/swap/actions'
 import { basisPointsToPercent } from './index'
 
-export const BASE_EXCHANGE_FEE = '0.4%' // Only used for display on string
+export const BASE_EXCHANGE_FEE = '0.4%' // Shown on swap page	// TODO need to update swap page for better description e.g. Swap Fee instead of Liquidity Provider Fee
+export const LP_PCT_SWAP_FEE = '0.35%' // Shown on add liquidity page (position card) and pool page
 export const BASE_WITHDRAW_FEE = 0.001 // Withdraw Fee (remove liquidity)
 export const BASE_FEE = new Percent(JSBI.BigInt(40), JSBI.BigInt(10000)) // 30 -> 40