Skip to content

update LP percentage swap fee #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bennyliaw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update LP percentage swap fee #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/PositionCard/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { useTokenBalance } from '../../state/wallet/hooks'
import { ExternalLink, TYPE } from '../../theme'
import { currencyId } from '../../utils/currencyId'
import { unwrappedToken } from '../../utils/wrappedCurrency'
import { BASE_EXCHANGE_FEE } from '../../utils/prices'
import { LP_PCT_SWAP_FEE } from '../../utils/prices'
import { ButtonPrimary, ButtonSecondary, ButtonEmpty } from '../Button'
import { transparentize } from 'polished'
import { CardNoise } from '../earn/styled'
Expand Down Expand Up @@ -149,7 +149,7 @@ export function MinimalPositionCard({ pair, showUnwrapped = false, border }: Pos
<span role="img" aria-label="wizard-icon">
⭐️
</span>{' '}
By adding liquidity you&apos;ll earn {BASE_EXCHANGE_FEE} of all trades on this pair proportional to your
By adding liquidity you&apos;ll earn {LP_PCT_SWAP_FEE} of all trades on this pair proportional to your
share of the pool. Fees are added to the pool, accrue in real time and can be claimed by withdrawing your
liquidity.
</TYPE.subHeader>
Expand Down
4 changes: 2 additions & 2 deletions src/pages/Pool/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { Pair } from '@luaswap/sdk'
import { Link } from 'react-router-dom'
import { SwapPoolTabs } from '../../components/NavigationTabs'

import { BASE_EXCHANGE_FEE } from '../../utils/prices'
import { LP_PCT_SWAP_FEE } from '../../utils/prices'

import FullPositionCard from '../../components/PositionCard'
import { useUserHasLiquidityInAllTokens } from '../../data/V1'
Expand Down Expand Up @@ -124,7 +124,7 @@ export default function Pool() {
</RowBetween>
<RowBetween>
<TYPE.white fontSize={14}>
{`Liquidity providers earn a ${BASE_EXCHANGE_FEE} fee on all trades proportional to their share of the pool. Fees are added to the pool, accrue in real time and can be claimed by withdrawing your liquidity.`}
{`Liquidity providers earn a ${LP_PCT_SWAP_FEE} fee on all trades proportional to their share of the pool. Fees are added to the pool, accrue in real time and can be claimed by withdrawing your liquidity.`}
</TYPE.white>
</RowBetween>
{/* <ExternalLink
Expand Down
3 changes: 2 additions & 1 deletion src/utils/prices.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ import { ALLOWED_PRICE_IMPACT_HIGH, ALLOWED_PRICE_IMPACT_LOW, ALLOWED_PRICE_IMPA
import { Field } from '../state/swap/actions'
import { basisPointsToPercent } from './index'

export const BASE_EXCHANGE_FEE = '0.4%' // Only used for display on string
export const BASE_EXCHANGE_FEE = '0.4%' // Shown on swap page // TODO need to update swap page for better description e.g. Swap Fee instead of Liquidity Provider Fee
export const LP_PCT_SWAP_FEE = '0.35%' // Shown on add liquidity page (position card) and pool page
export const BASE_WITHDRAW_FEE = 0.001 // Withdraw Fee (remove liquidity)
export const BASE_FEE = new Percent(JSBI.BigInt(40), JSBI.BigInt(10000)) // 30 -> 40

Expand Down