Weak reference operation to avoid strong reference capture in closure (#444)

aashishtamsya · web-flow · commit 1f17a65a21c2 · 2025-06-09T16:02:46.000+08:00
diff --git a/Sources/SwiftQueue/Constraint+Timeout.swift b/Sources/SwiftQueue/Constraint+Timeout.swift
@@ -39,7 +39,8 @@ internal final class TimeoutConstraint: SimpleConstraint, CodableConstraint {
     }
 
     override func run(operation: SqOperation) -> Bool {
-        operation.dispatchQueue.runAfter(timeout) {
+        operation.dispatchQueue.runAfter(timeout) { [weak operation] in
+            guard let operation else { return }
             if operation.isExecuting && !operation.isFinished {
                 operation.cancel(with: SwiftQueueError.timeout)
             }

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,8 @@ internal final class TimeoutConstraint: SimpleConstraint, CodableConstraint {`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`override func run(operation: SqOperation) -> Bool {`
`42`		`- operation.dispatchQueue.runAfter(timeout) {`
	`42`	`+ operation.dispatchQueue.runAfter(timeout) { [weak operation] in`
	`43`	`+ guard let operation else { return }`
`43`	`44`	`if operation.isExecuting && !operation.isFinished {`
`44`	`45`	`operation.cancel(with: SwiftQueueError.timeout)`
`45`	`46`	`}`