🛟 Arrumador: Configure Trunk, Mise and GitHub Actions#33
Conversation
- Configure `mise` with standard tasks (lint, fmt, test, codegen, install, ci, build). - Configure `trunk` for linting and formatting. - Consolidate GitHub Actions into `.github/workflows/autorelease.yml`. - Fix code issues in `cmd/dotenv/main.go` (unhandled errors, formatting). - Add basic test `cmd/dotenv/main_test.go`. - Update dependencies (Go 1.25.5, @trunkio/launcher 1.3.4). Co-authored-by: lucasew <15693688+lucasew@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary of ChangesHello @lucasew, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the project's development infrastructure by integrating Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces significant changes by configuring standard tooling (mise, trunk) and establishing a robust CI/CD pipeline via GitHub Actions. The changes include adding configuration files for mise and trunk, creating a new autorelease.yml workflow, and updating the Go version. Additionally, lint errors and bugs in cmd/dotenv/main.go have been fixed, and a new test file cmd/dotenv/main_test.go has been added. Overall, the changes aim to improve development workflow and code quality.
| if err != nil { | ||
| return err | ||
| } | ||
| defer func() { _ = f.Close() }() |
There was a problem hiding this comment.
The defer f.Close() statement should be placed immediately after os.Open(filename) to ensure the file is closed even if an error occurs during the subsequent operations. While the current placement works, it's a good practice to defer resource cleanup as soon as the resource is acquired.
| defer func() { _ = f.Close() }() | |
| defer func() { _ = f.Close() }() |
| if !foundDivider { | ||
| handleError(fmt.Errorf("missing divider (--)")) | ||
| } | ||
| _ = parseEnvTerm("@.env") |
There was a problem hiding this comment.
The return value of parseEnvTerm("@.env") is an error that is currently ignored. While it might be intentional to ignore errors for the default .env file, it's better to explicitly handle it or at least acknowledge it with a comment if it's truly meant to be ignored. Ignoring errors silently can hide potential issues.
| _ = parseEnvTerm("@.env") | |
| _ = parseEnvTerm("@.env") |
| func TestParseEnvTerm(t *testing.T) { | ||
| // Reset env | ||
| env = make(map[string]string) | ||
|
|
There was a problem hiding this comment.
It's good practice to reset the env map before each test case to ensure test isolation and prevent side effects from previous tests. This ensures that each test runs in a clean state.
| env = make(map[string]string) |
- Configure `mise` with standard tasks (lint, fmt, test, codegen, install, ci, build). - Configure `trunk` for linting and formatting. - Consolidate GitHub Actions into `.github/workflows/autorelease.yml`. - Fix code issues in `cmd/dotenv/main.go` (unhandled errors, formatting). - Add basic test `cmd/dotenv/main_test.go`. - Update dependencies (Go 1.26.0, @trunkio/launcher 1.3.4). - Use latest dependencies for GitHub Actions (checkout@v6, create-pull-request@v8). - Disable incompatible linters (golangci-lint2, nixpkgs-fmt). Co-authored-by: lucasew <15693688+lucasew@users.noreply.github.com>
1 participant
This PR configures standard tooling (
mise,trunk) and establishes a robust CI/CD pipeline via GitHub Actions.Changes:
mise.tomlwithgo,node,trunk,usage.trunkconfiguration..github/workflows/autorelease.ymlfollowing the required flow..github/workflows/update-deps.ymland oldautorelease.yml.cmd/dotenv/main.go.cmd/dotenv/main_test.go.PR created automatically by Jules for task 5275064478692297528 started by @lucasew